Re: Nasty surprise in 2.18.0

[Gary Gregory <ga...@gmail.com>]

Hi Piotr,

I see in the release notes that the fix made it in 2.19.0 RC1, thank you!

Gary

On Thu, Jul 21, 2022, 17:33 Gary Gregory <ga...@gmail.com> wrote:

> Hi Piotr,
>
> Thank you so much for the quick analysis!
>
> Gary
>
>
> On Thu, Jul 21, 2022, 17:35 Piotr P. Karwasz <pi...@gmail.com>
> wrote:
>
>> Hi Gary,
>>
>> > The script that starts our app uses an environment variable called
>> > LOG4J and starting with 2.18.0, Log4j puts the content of this
>> > environment variable in ALL system properties.
>> >
>> > Thoughts?
>>
>> Sorry, I must have broken it while fixing LOG4J-3413. The
>> ConsoleAppender is actually calling
>> PropertiesUtil.getCharsetProperty("sun.stdout.encoding") and:
>>
>> * it looks up a literal environment/system property
>> "sun.stdout.encoding" and finds nothing,
>> * it tokenizes "sun.stdout.encoding" and obtains an empty list of
>> tokens (this should prevent "configurationFile" to be confused with
>> "log4j2.configurationFile"),
>> * it normalizes the empty list of tokens and looks up a Java system
>> property named "log4j2" and an environment variable named "LOG4J".
>>
>> I'll fix it tomorrow and add a test.
>>
>> Piotr
>>
>

Re: Nasty surprise in 2.18.0

[Ralph Goers <ra...@dslextreme.com>]

> On Sep 12, 2022, at 11:58 PM, Piotr P. Karwasz <pi...@gmail.com> wrote:
> 
> On Tue, 13 Sept 2022 at 02:24, Ralph Goers <ra...@dslextreme.com> wrote:
>> 1. SLF4J2 support to make the Junit dependency test scope.
> 
> I fixed it yesterday, but if someone else can do a `mvn
> dependency:list -DincludeScope=runtime` and look for dependencies that
> should not be there, it would be better.
> 
>> 2. Fix GelfLayoutTest on Windows.
> 
> It disappeared on my Windows box after increasing the
> `EncodingListAppender` buffer size to 16 KiB. I committed the fix.


This may explain why it didn’t fail when I ran the build in my Windows 10 VM.

Ralph

Re: Nasty surprise in 2.18.0

["Piotr P. Karwasz" <pi...@gmail.com>]

On Tue, 13 Sept 2022 at 02:24, Ralph Goers <ra...@dslextreme.com> wrote:
> 1. SLF4J2 support to make the Junit dependency test scope.

I fixed it yesterday, but if someone else can do a `mvn
dependency:list -DincludeScope=runtime` and look for dependencies that
should not be there, it would be better.

> 2. Fix GelfLayoutTest on Windows.

It disappeared on my Windows box after increasing the
`EncodingListAppender` buffer size to 16 KiB. I committed the fix.

Piotr

Re: Nasty surprise in 2.18.0

[Ralph Goers <ra...@dslextreme.com>]

Unfortunately, I cancelled the vote for that. I need fixes for
1. SLF4J2 support to make the Junit dependency test scope.
2. Fix GelfLayoutTest on Windows.

If someone can let me know when these are fixed I will create a new release candidate.

Ralph

> On Sep 12, 2022, at 5:01 PM, Gary Gregory <ga...@gmail.com> wrote:
> 
> Hi Piotr,
> 
> I see in the release notes that the fix made it in 2.19.0 RC1, thank you!
> 
> Gary
> 
> On Thu, Jul 21, 2022, 17:33 Gary Gregory <ga...@gmail.com> wrote:
> 
>> Hi Piotr,
>> 
>> Thank you so much for the quick analysis!
>> 
>> Gary
>> 
>> 
>> On Thu, Jul 21, 2022, 17:35 Piotr P. Karwasz <pi...@gmail.com>
>> wrote:
>> 
>>> Hi Gary,
>>> 
>>>> The script that starts our app uses an environment variable called
>>>> LOG4J and starting with 2.18.0, Log4j puts the content of this
>>>> environment variable in ALL system properties.
>>>> 
>>>> Thoughts?
>>> 
>>> Sorry, I must have broken it while fixing LOG4J-3413. The
>>> ConsoleAppender is actually calling
>>> PropertiesUtil.getCharsetProperty("sun.stdout.encoding") and:
>>> 
>>> * it looks up a literal environment/system property
>>> "sun.stdout.encoding" and finds nothing,
>>> * it tokenizes "sun.stdout.encoding" and obtains an empty list of
>>> tokens (this should prevent "configurationFile" to be confused with
>>> "log4j2.configurationFile"),
>>> * it normalizes the empty list of tokens and looks up a Java system
>>> property named "log4j2" and an environment variable named "LOG4J".
>>> 
>>> I'll fix it tomorrow and add a test.
>>> 
>>> Piotr
>>> 
>>