You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/18 01:24:10 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
zhengruifeng opened a new pull request, #42966:
URL: https://github.com/apache/spark/pull/42966
### What changes were proposed in this pull request?
Add migration guide for Numpy minimum version upgrade
### Why are the changes needed?
to inform users about this important change
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
URL: https://github.com/apache/spark/pull/42966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42966:
URL: https://github.com/apache/spark/pull/42966#issuecomment-1722727476
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42966:
URL: https://github.com/apache/spark/pull/42966#discussion_r1328185625
##########
python/docs/source/migration_guide/pyspark_upgrade.rst:
##########
@@ -22,6 +22,8 @@ Upgrading PySpark
Upgrading from PySpark 3.5 to 4.0
---------------------------------
+* In Spark 4.0, the minimum supported version for Pandas has been raised from 1.0.5 to 1.4.4 in PySpark.
Review Comment:
I move the message for `pandas` and `numpy` to the beginning, since I think it is more important, otherwise they will be surrounded by the messages of Pandas APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42966:
URL: https://github.com/apache/spark/pull/42966#discussion_r1328185671
##########
python/docs/source/migration_guide/pyspark_upgrade.rst:
##########
@@ -22,6 +22,8 @@ Upgrading PySpark
Upgrading from PySpark 3.5 to 4.0
---------------------------------
+* In Spark 4.0, the minimum supported version for Pandas has been raised from 1.0.5 to 1.4.4 in PySpark.
Review Comment:
cc @itholic @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42966: [SPARK-45179][DOCS][FOLLOWUP] Add migration guide for Numpy minimum version upgrade
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42966:
URL: https://github.com/apache/spark/pull/42966#issuecomment-1722644456
CI link: https://github.com/zhengruifeng/spark/actions/runs/6216985551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org