You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2014/11/05 23:35:21 UTC

[GitHub] storm pull request: STORM-492 with reverting previous merge

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/308

    STORM-492 with reverting previous merge

    First of all, I'm sorry for mistake.
    It's for reverting broken #279 and reapply correct patch (using System Environment, not JVM Property).
    So you can find further information from #279.
    
    If Storm project has a rule about reverting and this PR doesn't fit, I'll wait @clockfly to revert, and re-create PR.
    
    @ptgoetz @clockfly @harshach Please take a look and comment. Thanks in advance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-492-with-revert-merge-and-renew

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #308
    
----
commit f880d619972bbbb0a1c3519298efbce260112ea6
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2014-11-05T22:07:22Z

    Revert "Merge branch 'STORM-492' of https://github.com/HeartSaVioR/storm into STORM-492"
    
    This reverts commit 1b8a32e2c3e8e624fc1ca1863898c3a10834151e, reversing
    changes made to a1e1c1e206bcc22d0721226531fb1328c2d8cd53.

commit 356f9f8b6e986d5e9113ade5a80a228d15b7bc86
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2014-11-05T22:20:24Z

    Let users override default test timeout
    
    * Fixed (bug) / Added time-ms from tracked-wait (trackedWait)
    * Provide a method to override default test timeout
    * Add a way to specify default test timeout in ms to DEVELOPER.md

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-492 with reverting previous merge

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/308#issuecomment-61897392
  
    Thanks @HeartSaVioR. No need to apologize, we all make mistakes. The important part is that we have a community to review and catch them. When we do. :)
    
    I'm fine with not reverting the other commit and just merging this one. It a small change.
    
    +1
    
    -Taylor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-492 with reverting previous merge

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/308#issuecomment-61931618
  
    Thank you for your kind words!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-492 with reverting previous merge

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/308


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-492 with reverting previous merge

Posted by harshach <gi...@git.apache.org>.

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/308#issuecomment-61898945
  
    Thanks for the quick fix. This looks good to me +1 on merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---