You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/04 21:14:08 UTC
Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/#review63951
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28716, 28717, 28718, 28719]
All tests passed.
- Mesos ReviewBot
On Dec. 5, 2014, 1:38 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28719/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 1:38 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
>
> Diff: https://reviews.apache.org/r/28719/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/#review64095
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28716, 28717, 28718, 28719]
All tests passed.
- Mesos ReviewBot
On Dec. 5, 2014, 9:26 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28719/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-2178
> https://issues.apache.org/jira/browse/MESOS-2178
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
>
> Diff: https://reviews.apache.org/r/28719/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 9:26 p.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-2178
https://issues.apache.org/jira/browse/MESOS-2178
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 9:23 p.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-2178
https://issues.apache.org/jira/browse/MESOS-2178
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 1:38 a.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
failed one test
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 12:08 a.m.)
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 11:06 p.m.)
Review request for mesos and Dominic Hamon.
Repository: mesos-git
Description
-------
Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
Diff: https://reviews.apache.org/r/28719/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/#review63918
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28716, 28717, 28718, 28719]
All tests passed.
- Mesos ReviewBot
On Dec. 4, 2014, 8:14 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28719/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 8:14 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
>
> Diff: https://reviews.apache.org/r/28719/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28719: libprocess: Introduced getIP and created
initialization wrappers for sockaddr_in and addrinfo
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28719/#review63906
-----------------------------------------------------------
Ship it!
Ship It!
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/28719/#comment106227>
please add an IPv6 TODO
- Dominic Hamon
On Dec. 4, 2014, 12:14 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28719/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:14 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp ab080c154095029c4a01d189a5fd8a178ba6c92e
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp 4db7d56af710577e08a9d7dbeb92a1f01559401f
>
> Diff: https://reviews.apache.org/r/28719/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>