You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/05/10 22:00:28 UTC
[GitHub] cordova-docs pull request: Update SQLite plugin details
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/600
Update SQLite plugin details
@brodybits to help review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-docs patch-6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #600
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Update SQLite plugin details
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-docs/pull/600#issuecomment-218708663
The updates look good to me, thanks!
FYI I dropped the Cordova engine constraint on Cordova-sqlite-storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Update SQLite plugin details
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-docs/pull/600#issuecomment-218391884
I don't think "relies on native SQLite implementation" is so relevant anymore. The cordova-sqlite-storage version now includes its own sqlite3 implementation. Also yours truly (@brodybits) broke the cordova-sqlite-storage README link.
For the README links, would it be an idea to consider using "#readme" at the end of the repo link instead of hardcoding the link through the default branch name?
FYI other changes may be coming:
- An "express-core" version that would use the built-in sqlite libraries for Android and iOS (not sure if we should really link this)
- The default branch of the SQLCipher version (for which there is no link) will probably change
- I may move or rename the "evfree" version.
In the past I would maintain the plugin source code in separate branches and publish a "*-master" branch that would also include the sqlite3 source/library dependencies. I changed cordova-sqlite-storage and cordova-sqlite-ext to fetch the sqlite3 source/library dependencies from npm (as discussed in cordova/cordova-discuss#38) and published them from lighter-weight branches. I expect to do the same for the SQLCipher and "evfree" versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Update SQLite plugin details
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org