You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:45:25 UTC

Review Request 70982: Added a test that driver re-registration does not unsuppress offers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70982/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9793
    https://issues.apache.org/jira/browse/MESOS-9793


Repository: mesos


Description
-------

Added a test that driver re-registration does not unsuppress offers.


Diffs
-----

  src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da 


Diff: https://reviews.apache.org/r/70982/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Re: Review Request 70982: Added a test that driver re-registration does not unsuppress offers.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70982/#review216296
-----------------------------------------------------------


Ship it!





src/tests/scheduler_driver_tests.cpp
Lines 403 (patched)
<https://reviews.apache.org/r/70982/#comment303475>

    re-registration typo



src/tests/scheduler_driver_tests.cpp
Lines 410 (patched)
<https://reviews.apache.org/r/70982/#comment303476>

    registration typo


- Benjamin Mahler


On July 1, 2019, 1:45 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70982/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 1:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9793
>     https://issues.apache.org/jira/browse/MESOS-9793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test that driver re-registration does not unsuppress offers.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da 
> 
> 
> Diff: https://reviews.apache.org/r/70982/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>