You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "ebarboni (via GitHub)" <gi...@apache.org> on 2023/04/12 16:51:02 UTC
[GitHub] [netbeans] ebarboni opened a new pull request, #5819: connection layout AOBE fix
ebarboni opened a new pull request, #5819:
URL: https://github.com/apache/netbeans/pull/5819
A colleague of mine found an AOBE in visual library. We have a quick fix with some test around. Hopefully next time he willl contribute by himself ðŸ¤.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #5819: connection layout AOBE fix
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #5819:
URL: https://github.com/apache/netbeans/pull/5819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5819: connection layout AOBE fix
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5819:
URL: https://github.com/apache/netbeans/pull/5819#discussion_r1164399858
##########
platform/api.visual/src/org/netbeans/modules/visual/layout/ConnectionWidgetLayout.java:
##########
@@ -86,7 +86,7 @@ public void layout (Widget widget) {
connectionWidget.calculateRouting ();
java.util.List<Point> controlPoints = connectionWidget.getControlPoints ();
- boolean empty = controlPoints == null || controlPoints.size () <= 0;
+ boolean empty = controlPoints == null || controlPoints.size () <= 1;
Review Comment:
yeah this does indeed look like a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists