You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Stephan Ewen <se...@apache.org> on 2019/12/03 11:30:42 UTC
[DISCUSS] Drop RequiredParameters and OptionType
I just stumbled across these classes recently and was looking for sample
uses.
No examples and other tests in the code base seem to use RequiredParameters
and OptionType.
They also seem quite redundant with how ParameterTool itself works
(tool.getRequired()).
Should we drop them, in an attempt to reduce unnecessary code and confusion
for users (multiple ways to do the same thing)? There are also many better
command line parsing libraries out there, this seems like something we
don't need to solve in Flink.
Best,
Stephan
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by vino yang <ya...@gmail.com>.
+1,
One concern: these two classes are marked with `@publicEvolving`
annotation.
Shall we mark them with `@Deprecated` annotation firstly?
Best,
Vino
Dian Fu <di...@gmail.com> 于2019年12月3日周二 下午8:56写道：
> +1 to remove them. It seems that we should also drop the class Option as
> it's currently only used in RequiredParameters.
>
> 在 2019年12月3日，下午8:34，Robert Metzger <rm...@apache.org> 写道：
>
> +1 on removing it.
>
> On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <se...@apache.org> wrote:
>
>> I just stumbled across these classes recently and was looking for sample
>> uses.
>> No examples and other tests in the code base seem to
>> use RequiredParameters and OptionType.
>>
>> They also seem quite redundant with how ParameterTool itself works
>> (tool.getRequired()).
>>
>> Should we drop them, in an attempt to reduce unnecessary code and
>> confusion for users (multiple ways to do the same thing)? There are also
>> many better command line parsing libraries out there, this seems like
>> something we don't need to solve in Flink.
>>
>> Best,
>> Stephan
>>
>
>
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by vino yang <ya...@gmail.com>.
+1,
One concern: these two classes are marked with `@publicEvolving`
annotation.
Shall we mark them with `@Deprecated` annotation firstly?
Best,
Vino
Dian Fu <di...@gmail.com> 于2019年12月3日周二 下午8:56写道：
> +1 to remove them. It seems that we should also drop the class Option as
> it's currently only used in RequiredParameters.
>
> 在 2019年12月3日，下午8:34，Robert Metzger <rm...@apache.org> 写道：
>
> +1 on removing it.
>
> On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <se...@apache.org> wrote:
>
>> I just stumbled across these classes recently and was looking for sample
>> uses.
>> No examples and other tests in the code base seem to
>> use RequiredParameters and OptionType.
>>
>> They also seem quite redundant with how ParameterTool itself works
>> (tool.getRequired()).
>>
>> Should we drop them, in an attempt to reduce unnecessary code and
>> confusion for users (multiple ways to do the same thing)? There are also
>> many better command line parsing libraries out there, this seems like
>> something we don't need to solve in Flink.
>>
>> Best,
>> Stephan
>>
>
>
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by Dian Fu <di...@gmail.com>.
+1 to remove them. It seems that we should also drop the class Option as it's currently only used in RequiredParameters.
> 在 2019年12月3日，下午8:34，Robert Metzger <rm...@apache.org> 写道：
>
> +1 on removing it.
>
> On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <sewen@apache.org <ma...@apache.org>> wrote:
> I just stumbled across these classes recently and was looking for sample uses.
> No examples and other tests in the code base seem to use RequiredParameters and OptionType.
>
> They also seem quite redundant with how ParameterTool itself works (tool.getRequired()).
>
> Should we drop them, in an attempt to reduce unnecessary code and confusion for users (multiple ways to do the same thing)? There are also many better command line parsing libraries out there, this seems like something we don't need to solve in Flink.
>
> Best,
> Stephan
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by Dian Fu <di...@gmail.com>.
+1 to remove them. It seems that we should also drop the class Option as it's currently only used in RequiredParameters.
> 在 2019年12月3日，下午8:34，Robert Metzger <rm...@apache.org> 写道：
>
> +1 on removing it.
>
> On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <sewen@apache.org <ma...@apache.org>> wrote:
> I just stumbled across these classes recently and was looking for sample uses.
> No examples and other tests in the code base seem to use RequiredParameters and OptionType.
>
> They also seem quite redundant with how ParameterTool itself works (tool.getRequired()).
>
> Should we drop them, in an attempt to reduce unnecessary code and confusion for users (multiple ways to do the same thing)? There are also many better command line parsing libraries out there, this seems like something we don't need to solve in Flink.
>
> Best,
> Stephan
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by Robert Metzger <rm...@apache.org>.
+1 on removing it.
On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <se...@apache.org> wrote:
> I just stumbled across these classes recently and was looking for sample
> uses.
> No examples and other tests in the code base seem to
> use RequiredParameters and OptionType.
>
> They also seem quite redundant with how ParameterTool itself works
> (tool.getRequired()).
>
> Should we drop them, in an attempt to reduce unnecessary code and
> confusion for users (multiple ways to do the same thing)? There are also
> many better command line parsing libraries out there, this seems like
> something we don't need to solve in Flink.
>
> Best,
> Stephan
>
Re: [DISCUSS] Drop RequiredParameters and OptionType
Posted by Robert Metzger <rm...@apache.org>.
+1 on removing it.
On Tue, Dec 3, 2019 at 12:31 PM Stephan Ewen <se...@apache.org> wrote:
> I just stumbled across these classes recently and was looking for sample
> uses.
> No examples and other tests in the code base seem to
> use RequiredParameters and OptionType.
>
> They also seem quite redundant with how ParameterTool itself works
> (tool.getRequired()).
>
> Should we drop them, in an attempt to reduce unnecessary code and
> confusion for users (multiple ways to do the same thing)? There are also
> many better command line parsing libraries out there, this seems like
> something we don't need to solve in Flink.
>
> Best,
> Stephan
>