You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2015/01/20 17:46:39 UTC
svn commit: r1653292 - /subversion/trunk/subversion/libsvn_fs_x/transaction.c
Author: stefan2
Date: Tue Jan 20 16:46:39 2015
New Revision: 1653292
URL: http://svn.apache.org/r1653292
Log:
Scanning through FSX/transaction.c found new instances where
single-pool functions don't require a second pool parameter.
* subversion/libsvn_fs_x/transaction.c
(get_lock_on_filesystem,
create_lock_baton): The POOL is a pure RESULT_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/transaction.c
Modified: subversion/trunk/subversion/libsvn_fs_x/transaction.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/transaction.c?rev=1653292&r1=1653291&r2=1653292&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/transaction.c (original)
+++ subversion/trunk/subversion/libsvn_fs_x/transaction.c Tue Jan 20 16:46:39 2015
@@ -182,12 +182,13 @@ with_txnlist_lock(svn_fs_t *fs,
}
-/* Get a lock on empty file LOCK_FILENAME, creating it in POOL. */
+/* Get a lock on empty file LOCK_FILENAME, creating it in RESULT_POOL. */
static svn_error_t *
get_lock_on_filesystem(const char *lock_filename,
- apr_pool_t *pool)
+ apr_pool_t *result_pool)
{
- return svn_error_trace(svn_io__file_lock_autocreate(lock_filename, pool));
+ return svn_error_trace(svn_io__file_lock_autocreate(lock_filename,
+ result_pool));
}
/* Reset the HAS_WRITE_LOCK member in the FFD given as BATON_VOID.
@@ -355,7 +356,8 @@ init_lock_baton(with_lock_baton_t *baton
/* Return the baton for the innermost lock of a (potential) lock chain.
The baton shall take out LOCK_ID from FS and execute BODY with BATON
- while the lock is being held. Allocate the result in a sub-pool of POOL.
+ while the lock is being held. Allocate the result in a sub-pool of
+ RESULT_POOL.
*/
static with_lock_baton_t *
create_lock_baton(svn_fs_t *fs,
@@ -363,11 +365,11 @@ create_lock_baton(svn_fs_t *fs,
svn_error_t *(*body)(void *baton,
apr_pool_t *scratch_pool),
void *baton,
- apr_pool_t *pool)
+ apr_pool_t *result_pool)
{
/* Allocate everything along the lock chain into a single sub-pool.
This minimizes memory usage and cleanup overhead. */
- apr_pool_t *lock_pool = svn_pool_create(pool);
+ apr_pool_t *lock_pool = svn_pool_create(result_pool);
with_lock_baton_t *result = apr_pcalloc(lock_pool, sizeof(*result));
/* Store parameters. */