[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1754: config merge

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #1754:
URL: https://github.com/apache/dubbo-go/pull/1754#discussion_r808682849



##########
File path: config/config_loader_options.go
##########
@@ -49,18 +52,22 @@ type loaderConf struct {
 
 	// user provide rootConfig built by config api
 	rc *RootConfig
+
+	// config file name
+	name string
 }
 
 func NewLoaderConf(opts ...LoaderConfOption) *loaderConf {
-	configFilePath := "../conf/dubbogo.yaml"
+	configFilePath := "./conf/dubbogo.yaml"

Review comment:
       云兴，有个疑问，这里把 dubbogo.yaml 固定住是否合适？是不是可以提供一个环境变量或者命令行接口，允许用户可定制




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org