You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 09:12:28 UTC
[GitHub] [flink] xiaoHoly opened a new pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
xiaoHoly opened a new pull request #14616:
URL: https://github.com/apache/flink/pull/14616
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
## Brief change log
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* aac6ca6fa0792f2ecb4d982545fea6403115f24b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031)
* f429967b7680aa4dce4212ddb01b2c107b3b7117 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* aac6ca6fa0792f2ecb4d982545fea6403115f24b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031)
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759192837
Thanks @xiaoHoly , I will help to review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760755775
It looks like the build was successful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* e57906f184411f95085433096ec5cffb2ec7ed88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016)
* aac6ca6fa0792f2ecb4d982545fea6403115f24b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 7ae8320042ec2e4390961c202f1c126f2ba07384 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932)
* 088770300dee0faec4b956833dccef115b05bbb7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "760153999",
"triggerType" : "MANUAL"
}, {
"hash" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12090",
"triggerID" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 043d57501a1c07d476e7b9490faa066eb947a98f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12090)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760153909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759975195
The conflict has been resolved @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f1147e571aba6a47340b4e5804266de2c927a0a1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989)
* b3875cab8dcd4fe128f099718b53e5e5af26ac27 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759412589
@wuchong ,Thanks for "setup" doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 088770300dee0faec4b956833dccef115b05bbb7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14616:
URL: https://github.com/apache/flink/pull/14616#discussion_r556307216
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalSortMergeJoin.scala
##########
@@ -189,7 +189,7 @@ class BatchPhysicalSortMergeJoin(
rightAllKey,
filterNulls,
condition,
- estimateOutputSize(getLeft) < estimateOutputSize(getRight),
+ estimateOutputSize(getLeft) < estimateOutputSize(getRight),
Review comment:
Please revert this.
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -42,8 +42,8 @@
*
* <p>TODO: This method can be removed once FLINK-20879 is finished.
*/
- public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
- return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();
+ public static long getMemorySize(TableConfig tableConfig, ConfigOption<MemorySize> option) {
Review comment:
I think we don't need this utility method anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 3ab1ce460fa37cc33355462cfefa7aed970bd092 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013)
* e57906f184411f95085433096ec5cffb2ec7ed88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on a change in pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on a change in pull request #14616:
URL: https://github.com/apache/flink/pull/14616#discussion_r556312510
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -42,8 +42,8 @@
*
* <p>TODO: This method can be removed once FLINK-20879 is finished.
*/
- public static long getMemorySize(TableConfig tableConfig, ConfigOption<String> option) {
- return MemorySize.parse(tableConfig.getConfiguration().getString(option)).getBytes();
+ public static long getMemorySize(TableConfig tableConfig, ConfigOption<MemorySize> option) {
Review comment:
okey~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 37e1dac970b011ef214d7fee59b36d7f4646b0e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 7ae8320042ec2e4390961c202f1c126f2ba07384 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "760153999",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "760153999",
"triggerType" : "MANUAL"
}, {
"hash" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
* 043d57501a1c07d476e7b9490faa066eb947a98f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759495114
The build is still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758527007
cc,@wuchong .please review this change,thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759902228
> The following case is failed:
>
> ```
> [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.404 s <<< FAILURE! - in org.apache.flink.table.client.gateway.local.ExecutionContextTest
> [ERROR] testConfiguration(org.apache.flink.table.client.gateway.local.ExecutionContextTest) Time elapsed: 0.018 s <<< FAILURE!
> java.lang.AssertionError: expected:<128kb> but was:<128 kb>
> ```
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760597538
The docs tests are failed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=12037&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=62110053-334f-5295-a0ab-80dd7e2babbf&l=33256
```
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ConfigOptionsDocsCompletenessITCase.testCompleteness:77->compareDocumentedAndExistingOptions:221 Documentation is outdated, please regenerate it according to the instructions in flink-docs/README.md.
Problems:
Documentation of table.exec.spill-compression.block-size in ExecutionConfigOptions is outdated. Expected: default=(64 kb) description=(The memory size used to do compress when spilling data. The larger the memory, the higher the compression ratio, but more memory resource will be consumed by the job.).
Documented option table.exec.spill-compression.block-size does not exist.
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* da3f76c58b1757b4c592485c4717ab5630e03d81 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758644200
Hi @xiaoHoly , could you rebase the branch to resovle the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758518623
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 043d57501a1c07d476e7b9490faa066eb947a98f (Fri May 28 07:08:37 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759966071
ok,a piece of cake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758518623
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 448c026a402e045e050f405daf934a8a7c880c9d (Tue Jan 12 09:15:12 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759955407
Thanks for review, @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* e57906f184411f95085433096ec5cffb2ec7ed88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* b3875cab8dcd4fe128f099718b53e5e5af26ac27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* da3f76c58b1757b4c592485c4717ab5630e03d81 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760015927
> The compile is failed again...
fix again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14616:
URL: https://github.com/apache/flink/pull/14616#discussion_r556339807
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/utils/ExecNodeUtil.java
##########
@@ -37,15 +37,6 @@
/** An Utility class that helps translating {@link ExecNode} to {@link Transformation}. */
public class ExecNodeUtil {
- /**
Review comment:
Remember to remove useless imports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* b3875cab8dcd4fe128f099718b53e5e5af26ac27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995)
* 3ab1ce460fa37cc33355462cfefa7aed970bd092 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759494757
The build is still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "760153999",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"triggerType" : "PUSH"
}, {
"hash" : "f429967b7680aa4dce4212ddb01b2c107b3b7117",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037",
"triggerID" : "760153999",
"triggerType" : "MANUAL"
}, {
"hash" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12090",
"triggerID" : "043d57501a1c07d476e7b9490faa066eb947a98f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f429967b7680aa4dce4212ddb01b2c107b3b7117 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12037)
* 043d57501a1c07d476e7b9490faa066eb947a98f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12090)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 37e1dac970b011ef214d7fee59b36d7f4646b0e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974)
* f1147e571aba6a47340b4e5804266de2c927a0a1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 3ab1ce460fa37cc33355462cfefa7aed970bd092 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758602392
cc,@godfreyhe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 088770300dee0faec4b956833dccef115b05bbb7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955)
* 37e1dac970b011ef214d7fee59b36d7f4646b0e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759899885
The following case is failed:
```
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.404 s <<< FAILURE! - in org.apache.flink.table.client.gateway.local.ExecutionContextTest
[ERROR] testConfiguration(org.apache.flink.table.client.gateway.local.ExecutionContextTest) Time elapsed: 0.018 s <<< FAILURE!
java.lang.AssertionError: expected:<128kb> but was:<128 kb>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* b3875cab8dcd4fe128f099718b53e5e5af26ac27 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995)
* 3ab1ce460fa37cc33355462cfefa7aed970bd092 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* da3f76c58b1757b4c592485c4717ab5630e03d81 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918)
* 7ae8320042ec2e4390961c202f1c126f2ba07384 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* 3ab1ce460fa37cc33355462cfefa7aed970bd092 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013)
* e57906f184411f95085433096ec5cffb2ec7ed88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759410046
You can setup the formatting plugin which can help you auto-format the code.
https://ci.apache.org/projects/flink/flink-docs-master/flinkDev/ide_setup.html#code-formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760011288
The compile is failed again...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
}, {
"hash" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11995",
"triggerID" : "b3875cab8dcd4fe128f099718b53e5e5af26ac27",
"triggerType" : "PUSH"
}, {
"hash" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12013",
"triggerID" : "3ab1ce460fa37cc33355462cfefa7aed970bd092",
"triggerType" : "PUSH"
}, {
"hash" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12016",
"triggerID" : "e57906f184411f95085433096ec5cffb2ec7ed88",
"triggerType" : "PUSH"
}, {
"hash" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031",
"triggerID" : "aac6ca6fa0792f2ecb4d982545fea6403115f24b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* aac6ca6fa0792f2ecb4d982545fea6403115f24b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12031)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759964282
@xiaoHoly , there is a conflict, could you rebase the branch again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-760115634
Hi,@wuchong ,Test - libraries error,How to fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xiaoHoly commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
xiaoHoly commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-759165382
@wuchong ,Jark, I hava resovle the conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14616:
URL: https://github.com/apache/flink/pull/14616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14616: [FLINK-20879][table-api] Use MemorySize type instead of String type for memory ConfigOption in ExecutionConfigOptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14616:
URL: https://github.com/apache/flink/pull/14616#issuecomment-758526377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "448c026a402e045e050f405daf934a8a7c880c9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "448c026a402e045e050f405daf934a8a7c880c9d",
"triggerType" : "PUSH"
}, {
"hash" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11918",
"triggerID" : "da3f76c58b1757b4c592485c4717ab5630e03d81",
"triggerType" : "PUSH"
}, {
"hash" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11932",
"triggerID" : "7ae8320042ec2e4390961c202f1c126f2ba07384",
"triggerType" : "PUSH"
}, {
"hash" : "088770300dee0faec4b956833dccef115b05bbb7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11955",
"triggerID" : "088770300dee0faec4b956833dccef115b05bbb7",
"triggerType" : "PUSH"
}, {
"hash" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11974",
"triggerID" : "37e1dac970b011ef214d7fee59b36d7f4646b0e1",
"triggerType" : "PUSH"
}, {
"hash" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989",
"triggerID" : "f1147e571aba6a47340b4e5804266de2c927a0a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 448c026a402e045e050f405daf934a8a7c880c9d UNKNOWN
* f1147e571aba6a47340b4e5804266de2c927a0a1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org