You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:53:46 UTC
[GitHub] [incubator-kyuubi] cfmcgrady opened a new pull request #1907: [WIP][KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
cfmcgrady opened a new pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
TODO
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] jiwq commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805952447
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -179,4 +178,20 @@ object Logging {
val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
"org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
}
+
+ /**
+ * Return true if log4j2 is initialized by default configuration which has one
+ * appender with error level. See `org.apache.logging.log4j.core.config.DefaultConfiguration`.
+ */
+ private def islog4j2DefaultConfigured(): Boolean = {
Review comment:
```suggestion
private def isLog4j2DefaultConfigured(): Boolean = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b0d026) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **increase** coverage by `0.02%`.
> The diff coverage is `16.66%`.
> :exclamation: Current head 2b0d026 differs from pull request most recent head 3597a27. Consider uploading reports for the commit 3597a27 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
+ Coverage 59.75% 59.77% +0.02%
- Complexity 321 324 +3
============================================
Files 291 292 +1
Lines 14234 14249 +15
Branches 1806 1810 +4
============================================
+ Hits 8506 8518 +12
- Misses 5003 5005 +2
- Partials 725 726 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.98% <16.66%> (-0.70%)` | :arrow_down: |
| [.../kyuubi/engine/trino/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRUYWJsZVR5cGVzLnNjYWxh) | `90.00% <0.00%> (ø)` | |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `61.53% <0.00%> (+11.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...3597a27](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c43b46) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **increase** coverage by `0.01%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head 2c43b46 differs from pull request most recent head b19bca6. Consider uploading reports for the commit b19bca6 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
+ Coverage 59.75% 59.77% +0.01%
- Complexity 321 324 +3
============================================
Files 291 292 +1
Lines 14234 14250 +16
Branches 1806 1810 +4
============================================
+ Hits 8506 8518 +12
- Misses 5003 5006 +3
- Partials 725 726 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.48% <14.28%> (-1.20%)` | :arrow_down: |
| [.../kyuubi/engine/trino/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRUYWJsZVR5cGVzLnNjYWxh) | `90.00% <0.00%> (ø)` | |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `61.53% <0.00%> (+11.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...b19bca6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [WIP][KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd7a8fc) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **decrease** coverage by `0.02%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head fd7a8fc differs from pull request most recent head 2c43b46. Consider uploading reports for the commit 2c43b46 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
- Coverage 59.75% 59.73% -0.03%
Complexity 321 321
============================================
Files 291 291
Lines 14234 14239 +5
Branches 1806 1809 +3
============================================
Hits 8506 8506
- Misses 5003 5006 +3
- Partials 725 727 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.48% <14.28%> (-1.20%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...2c43b46](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1039797312
thanks @cfmcgrady for the fix and @jiwq @link3280 for the review, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038865795
cc @pan3793 @yaooqinn @turboFei @link3280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805710488
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -179,4 +179,20 @@ object Logging {
val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
"org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
}
+
+ /**
+ * Return true if log4j2 is initialized by default configuration which has one
+ * appender with error level. See `org.apache.logging.log4j.core.config.DefaultConfiguration`.
+ */
+ private[kyuubi] def islog4j2DefaultConfigured(): Boolean = {
Review comment:
private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038929283
I have tested it locally, LGTM overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1907: [WIP][KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd7a8fc) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **decrease** coverage by `0.02%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head fd7a8fc differs from pull request most recent head 1ab8ca4. Consider uploading reports for the commit 1ab8ca4 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
- Coverage 59.75% 59.73% -0.03%
Complexity 321 321
============================================
Files 291 291
Lines 14234 14239 +5
Branches 1806 1809 +3
============================================
Hits 8506 8506
- Misses 5003 5006 +3
- Partials 725 727 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.48% <14.28%> (-1.20%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...1ab8ca4](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] jiwq commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805951238
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Agree to @link3280 . If need change, should better modify global.
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -179,4 +178,20 @@ object Logging {
val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
"org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
}
+
+ /**
+ * Return true if log4j2 is initialized by default configuration which has one
+ * appender with error level. See `org.apache.logging.log4j.core.config.DefaultConfiguration`.
+ */
+ private def islog4j2DefaultConfigured(): Boolean = {
Review comment:
```suggestion
private def isLog4j2DefaultConfigured(): Boolean = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b19bca6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **increase** coverage by `0.01%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head b19bca6 differs from pull request most recent head 2b0d026. Consider uploading reports for the commit 2b0d026 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
+ Coverage 59.75% 59.77% +0.01%
- Complexity 321 324 +3
============================================
Files 291 292 +1
Lines 14234 14250 +16
Branches 1806 1810 +4
============================================
+ Hits 8506 8518 +12
- Misses 5003 5006 +3
- Partials 725 726 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.48% <14.28%> (-1.20%)` | :arrow_down: |
| [.../kyuubi/engine/trino/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRUYWJsZVR5cGVzLnNjYWxh) | `90.00% <0.00%> (ø)` | |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `61.53% <0.00%> (+11.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...2b0d026](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805759049
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -92,16 +93,15 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean): Unit = {
if (Logging.isLog4j2) {
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
// scalastyle:off println
- if (!log4j2Initialized) {
+ if (Logging.islog4j2DefaultConfigured()) {
Logging.useDefault = true
val defaultLogProps = "log4j2-defaults.properties"
Option(Thread.currentThread().getContextClassLoader.getResource(defaultLogProps)) match {
case Some(url) =>
val context = LogManager.getContext(false).asInstanceOf[LoggerContext]
context.setConfigLocation(url.toURI)
+ System.err.println(s"Using Kyuubi's default log4j profile: $url")
Review comment:
Only for debug, it's ok for me to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] link3280 commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
link3280 commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805863117
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Minor: should we keep it in lower case to align with others?
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Minor: should we keep it in lower case to align with the others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1039797312
thanks @cfmcgrady for the fix and @jiwq @link3280 for the review, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805711420
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -92,16 +93,15 @@ trait Logging {
private def initializeLogging(isInterpreter: Boolean): Unit = {
if (Logging.isLog4j2) {
- val log4j2Initialized = !LogManager.getRootLogger
- .asInstanceOf[org.apache.logging.log4j.core.Logger].getAppenders.isEmpty
// scalastyle:off println
- if (!log4j2Initialized) {
+ if (Logging.islog4j2DefaultConfigured()) {
Logging.useDefault = true
val defaultLogProps = "log4j2-defaults.properties"
Option(Thread.currentThread().getContextClassLoader.getResource(defaultLogProps)) match {
case Some(url) =>
val context = LogManager.getContext(false).asInstanceOf[LoggerContext]
context.setConfigLocation(url.toURI)
+ System.err.println(s"Using Kyuubi's default log4j profile: $url")
Review comment:
looks unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] link3280 commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
link3280 commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805863117
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Minor: should we keep in lower case to align with others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#issuecomment-1038809084
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1907](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b0d026) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a6480d0e31b72ccca0e8f2a0aa49bfd6f0e8f36e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6480d0) will **increase** coverage by `0.02%`.
> The diff coverage is `16.66%`.
> :exclamation: Current head 2b0d026 differs from pull request most recent head d69cd11. Consider uploading reports for the commit d69cd11 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
+ Coverage 59.75% 59.77% +0.02%
- Complexity 321 324 +3
============================================
Files 291 292 +1
Lines 14234 14249 +15
Branches 1806 1810 +4
============================================
+ Hits 8506 8518 +12
- Misses 5003 5005 +2
- Partials 725 726 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `36.98% <16.66%> (-0.70%)` | :arrow_down: |
| [.../kyuubi/engine/trino/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRUYWJsZVR5cGVzLnNjYWxh) | `90.00% <0.00%> (ø)` | |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `61.53% <0.00%> (+11.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6480d0...d69cd11](https://codecov.io/gh/apache/incubator-kyuubi/pull/1907?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] jiwq commented on a change in pull request #1907: [KYUUBI #1905] log4j2-defaults.properties is not working since log4j 2 is always intialized by default
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805951238
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Agree to @link3280 . If need change, should better modify global.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org