[GitHub] [incubator-druid] leventov commented on a change in pull request #7541: Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7541: Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings
URL: https://github.com/apache/incubator-druid/pull/7541#discussion_r278262685
 
 

 ##########
 File path: .idea/misc.xml
 ##########
 @@ -69,10 +74,16 @@
           <item index="6" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.NonNull" />
           <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullDecl" />
           <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullType" />
+          <item index="9" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNonNull" />
+          <item index="10" class="java.lang.String" itemvalue="com.android.annotations.NonNull" />
         </list>
       </value>
     </option>
   </component>
+  <component name="ProjectResources">
 
 Review comment:
   > Why do they need to be added, rather than referenced somehow without copying? 
   
   IntelliJ verifies XML documents by the schema. XML documents usually reference those schemas as URLs:
   ```
   <assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
             xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
   ```
   But IntelliJ doesn't automatically go to the internet to download the resource. It needs to know what schema corresponds to what URL, statically.
   
   > (Would make a good comment here)
   
   Unfortunately, IntelliJ has a bad habit of purging comments from these settings XMLs, so adding comments is not productive: https://youtrack.jetbrains.com/issue/IDEA-211087.
   
   > Will there be a need to update them in the future, and if so what would trigger that? Or are these files not expected to update regularly?
   
   No, these schema documents are expected to be immutable forever. If it will be updated, it will be `http://maven.apache.org/xsd/assembly-2.0.1.xsd`, or whatever another version.
   
   > I don't see a license attached to assembly-2.0.0.xsd -- meaning we need to add a comment describing the legal basis for being able to include this file. Ideally this comment takes the form of a statement of what license the file is being used under, and why we believe it falls under that license. Even separately from the legal reason for including a comment, it would be good just to document where the file came from.
   
   This document is created and managed by Apache Maven, so it must be under Apache license. I don't feel confident to edit the file themselves, so that it actually diverges from the contents of http://maven.apache.org/xsd/assembly-2.0.0.xsd.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org