You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/08/05 20:39:46 UTC
[kudu-CR] [scripts] fix y-axis label for benchmarks.sh
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16293
Change subject: [scripts] fix y-axis label for benchmarks.sh
......................................................................
[scripts] fix y-axis label for benchmarks.sh
This patch brings Y axis labels in sync with the actual metrics shown
in graphs generated by benchmarks.sh.
Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 29 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/16293/1
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [scripts] fix y-axis label for benchmarks.sh
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16293 )
Change subject: [scripts] fix y-axis label for benchmarks.sh
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh
File src/kudu/scripts/benchmarks.sh:
http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh@664
PS2, Line 664: row/sec, row/cpusec
Why are there two units here?
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Aug 2020 19:18:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [scripts] fix y-axis label in benchmarks.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16293
to look at the new patch set (#3).
Change subject: [scripts] fix y-axis label in benchmarks.sh
......................................................................
[scripts] fix y-axis label in benchmarks.sh
This patch brings Y axis labels in sync with the actual metrics shown
in graphs generated by benchmarks.sh.
In addition, I split the graphs for the multi-thread insert test into
separate throughput and CPU efficiency graphs.
Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 32 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/16293/3
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] fix y-axis label for benchmarks.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16293
to look at the new patch set (#2).
Change subject: [scripts] fix y-axis label for benchmarks.sh
......................................................................
[scripts] fix y-axis label for benchmarks.sh
This patch brings Y axis labels in sync with the actual metrics shown
in graphs generated by benchmarks.sh.
Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 29 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/16293/2
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] fix y-axis label in benchmarks.sh
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16293 )
Change subject: [scripts] fix y-axis label in benchmarks.sh
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Aug 2020 23:32:05 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] fix y-axis label in benchmarks.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16293 )
Change subject: [scripts] fix y-axis label in benchmarks.sh
......................................................................
[scripts] fix y-axis label in benchmarks.sh
This patch brings Y axis labels in sync with the actual metrics shown
in graphs generated by benchmarks.sh.
In addition, I split the graphs for the multi-thread insert test into
separate throughput and CPU efficiency graphs.
Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Reviewed-on: http://gerrit.cloudera.org:8080/16293
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 32 insertions(+), 25 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] fix y-axis label for benchmarks.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16293 )
Change subject: [scripts] fix y-axis label for benchmarks.sh
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh
File src/kudu/scripts/benchmarks.sh:
http://gerrit.cloudera.org:8080/#/c/16293/2/src/kudu/scripts/benchmarks.sh@664
PS2, Line 664: row/sec, row/cpusec
> Why are there two units here?
The generated plot contains two data series: one is throughput (rows per wall-second), another is total CPU usage of both the client and server (rows per cpu-second).
* https://gerrit.cloudera.org/#/c/16293/2/src/kudu/scripts/benchmarks.sh@477
* https://gerrit.cloudera.org/#/c/16293/2/src/kudu/scripts/benchmarks.sh@479
I'm not sure it makes sense to keep those at the same plot because the difference is in the order of a multiple of CPU cores in the system. I'll separate those, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/16293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5fb5efa742f2321ad8d52a794311defff620e9
Gerrit-Change-Number: 16293
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Aug 2020 19:39:57 +0000
Gerrit-HasComments: Yes