You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dheerenmohta (via GitHub)" <gi...@apache.org> on 2026/08/19 10:15:14 UTC
[PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]
dheerenmohta opened a new pull request, #71830:
URL: https://github.com/apache/airflow/pull/71830
The auto-generated result-backend connection secret built the PgBouncer hostname from .Release.Name directly, omitting the namespace — unlike the already-correct sibling logic in the metadata connection secret. This silently breaks Celery result-backend to PgBouncer routing whenever useStandardNaming (the chart's own recommended setting) or fullnameOverride is used, since the rendered PgBouncer Service name diverges from .Release.Name.
Derives the PgBouncer host the same way the metadata secret already does, and adds a regression test covering the useStandardNaming: true case.
Note: this does not fully resolve #54875's original ask. Auto-configuring PgBouncer when the metadata connection is backed by an externally-managed, opaque Kubernetes Secret isn't something Helm templating can do, since it can't introspect that Secret's contents at render time. This fixes a real, narrower, verified bug in the chart's own auto-generated-secret path.
related: #54875
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Sonnet 5)
Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]
Posted by "dheerenmohta (via GitHub)" <gi...@apache.org>.
dheerenmohta commented on PR #71830:
URL: https://github.com/apache/airflow/pull/71830#issuecomment-5579808504
The review-fix commit (448d6fd292, now merged into b6efaf393b after also picking up the current upstream/main) addressed both comments:
- Removed the placeholder newsfragment.
- Removed the redundant test comment — the test name already carries that intent.
CI is now fully green (the earlier newsfragment-check failure was caused by a stale merge commit that dragged in an unrelated old file; that's been cleaned up too). Let me know if there's anything else to adjust.
---
Drafted-by: Claude Code (Sonnet 5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #71830:
URL: https://github.com/apache/airflow/pull/71830#issuecomment-5340686354
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on code in PR #71830:
URL: https://github.com/apache/airflow/pull/71830#discussion_r3914960152
##########
chart/tests/helm_tests/security/test_result_backend_connection_secret.py:
##########
@@ -127,7 +127,23 @@ def test_should_set_pgbouncer_overrides_with_non_chart_database_when_enabled(sel
# host, port, dbname still get overridden even with an non-chart db
assert (
- connection == "db+postgresql://someuser:somepass@release-name-pgbouncer:6543"
+ connection == "db+postgresql://someuser:somepass@release-name-pgbouncer.default:6543"
+ "/release-name-result-backend?sslmode=allow"
+ )
+
+ def test_should_set_pgbouncer_overrides_with_use_standard_naming(self):
+ # The pgbouncer host must be derived from the "airflow.fullname" template (like the metadata
Review Comment:
This is how useStandardNaming/fullnameOverride works, so we can delete this comment here. Test name is descriptive enough.
##########
chart/newsfragments/PR_NUMBER_PLACEHOLDER.bugfix.rst:
##########
@@ -0,0 +1 @@
+Fix PgBouncer connection routing in the auto-generated result backend secret to use the ``airflow.fullname`` naming convention, matching the metadata connection secret. Previously it pointed at a non-existent PgBouncer host whenever ``useStandardNaming`` or ``fullnameOverride`` changed the release naming.
Review Comment:
I think we can delete this newsfragment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Helm: Fix PgBouncer hostname for result backend under standard naming [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl merged PR #71830:
URL: https://github.com/apache/airflow/pull/71830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org