You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/03 14:58:58 UTC

[jira] [Commented] (BEAM-889) CheckpointDir option does not accept relative path and requires protocol

    [ https://issues.apache.org/jira/browse/BEAM-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632986#comment-15632986 ] 

ASF GitHub Bot commented on BEAM-889:
-------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/incubator-beam/pull/1271

    [BEAM-889] CheckpointDir option does not accept relative path and req…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    …uires protocol.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/incubator-beam master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1271
    
----
commit 2bf8163290bae3273ad068daf8f3776a8a8ad9cd
Author: Sela <an...@paypal.com>
Date:   2016-11-03T14:56:08Z

    [BEAM-889] CheckpointDir option does not accept relative path and requires protocol.

----


> CheckpointDir option does not accept relative path and requires protocol
> ------------------------------------------------------------------------
>
>                 Key: BEAM-889
>                 URL: https://issues.apache.org/jira/browse/BEAM-889
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>            Priority: Minor
>
> I tried to be super strict here and this seems like a mistake.
> Spark will assert on the provided checkpointDir so no need to double check.
> We should however WARN in the log in case the provided path doesn't match a known reliable FS, such as: hdfs, gs, s3. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)