You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/17 19:16:54 UTC
[kudu-CR] [spark] Seperate out DeafultSourceTests
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14491
Change subject: [spark] Seperate out DeafultSourceTests
......................................................................
[spark] Seperate out DeafultSourceTests
We have seen flaky test failures due to timeouts of DeafultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14491/1
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
[spark] Separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14491/4
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14491
to look at the new patch set (#2).
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
[spark] Separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14491/2
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] [spark] Seperate out DeafultSourceTests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Seperate out DeafultSourceTests
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG@7
PS1, Line 7: [spark] Seperate out DeafultSourceTests
"Separate out DefaultSourceTests"
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG@9
PS1, Line 9: DeafultSourceTest
DefaultSourceTest
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 19:54:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
[spark] Separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Reviewed-on: http://gerrit.cloudera.org:8080/14491
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG@7
PS1, Line 7: [spark] Seperate out DeafultSourceTests
> "Separate out DefaultSourceTests"
Done
http://gerrit.cloudera.org:8080/#/c/14491/1//COMMIT_MSG@9
PS1, Line 9: DeafultSourceTest
> DefaultSourceTest
Done
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 19:57:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [spark] separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] separate out DefaultSourceTests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Oct 2019 00:35:15 +0000
Gerrit-HasComments: No
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 19:58:57 +0000
Gerrit-HasComments: No
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 21:23:36 +0000
Gerrit-HasComments: No
[kudu-CR] [spark] separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] separate out DefaultSourceTests
......................................................................
[spark] separate out DefaultSourceTests
We have seen flaky test failures due to timeouts of DefaultSourceTest.
This is primarily due to the sheer number of tests in that class.
This patch break out the SQL based tests, ones using `sqlContext.sql(…)`
into their own class. There is no change in test methods or coverage.
The result is 22 DefaultSourceTests and 22 SparkSQLTests.
Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
---
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
A java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
3 files changed, 548 insertions(+), 497 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/14491/3
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [spark] Separate out DefaultSourceTests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 )
Change subject: [spark] Separate out DefaultSourceTests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54aa0327ffb5254c03fcfe8a0a08dba230360a40
Gerrit-Change-Number: 14491
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 21:14:09 +0000
Gerrit-HasComments: No