You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/03 20:38:22 UTC
Review Request 28664: Added duplicated persistence id check in
ResourceChecker.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28664/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2030
https://issues.apache.org/jira/browse/MESOS-2030
Repository: mesos-git
Description
-------
Added duplicated persistence id check in ResourceChecker.
Diffs
-----
src/master/master.cpp 99b5a2042377481f933379cf35d4715f7d771efa
src/tests/resource_offers_tests.cpp c8c25d75d93b6e9e25d35cb9953f9c91dfbbbd14
Diff: https://reviews.apache.org/r/28664/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28664: Added duplicated persistence id check in
ResourceChecker.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28664/#review63764
-----------------------------------------------------------
Ship it!
This is only a partial check for duplicate IDs, can you add a TODO expressing that we need to check for duplicate IDs on the slave's existing tasks?
If you do the testing cleanup, it would be easy to test the other interesting cases:
(1) Duplicate ID across task + executor.
(2) Duplicate ID within executor.
Mind following up separately with the testing cleanup, and for now, drop a TODO for testing (1) and (2)?
src/master/master.cpp
<https://reviews.apache.org/r/28664/#comment106060>
Per my comment above, can you add a TODO here?
- Ben Mahler
On Dec. 3, 2014, 7:38 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28664/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:38 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added duplicated persistence id check in ResourceChecker.
>
>
> Diffs
> -----
>
> src/master/master.cpp 99b5a2042377481f933379cf35d4715f7d771efa
> src/tests/resource_offers_tests.cpp c8c25d75d93b6e9e25d35cb9953f9c91dfbbbd14
>
> Diff: https://reviews.apache.org/r/28664/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28664: Added duplicated persistence id check in
ResourceChecker.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28664/#review63729
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28616, 28618, 28626, 28627, 28664]
All tests passed.
- Mesos ReviewBot
On Dec. 3, 2014, 7:38 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28664/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:38 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added duplicated persistence id check in ResourceChecker.
>
>
> Diffs
> -----
>
> src/master/master.cpp 99b5a2042377481f933379cf35d4715f7d771efa
> src/tests/resource_offers_tests.cpp c8c25d75d93b6e9e25d35cb9953f9c91dfbbbd14
>
> Diff: https://reviews.apache.org/r/28664/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>