You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/02 18:33:30 UTC

[GitHub] [kafka] lct45 opened a new pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

lct45 opened a new pull request #9248:
URL: https://github.com/apache/kafka/pull/9248


   Updated number of expected messages
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9248:
URL: https://github.com/apache/kafka/pull/9248#issuecomment-686058224


   Yep, that looks like the only test that failed. Thanks, @ableegoldman .
   
   Yes, the checks output leaves something to be desired. I don't know how easy/possible it is to improve it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei merged pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #9248:
URL: https://github.com/apache/kafka/pull/9248


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #9248:
URL: https://github.com/apache/kafka/pull/9248#issuecomment-686044360


   One unrelated test failed:
   `Build / JDK 8 / testNoConnectionLimitsByDefault – kafka.network.ConnectionQuotasTest`
   
   Also, why are there so many different builds now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman edited a comment on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

Posted by GitBox <gi...@apache.org>.
ableegoldman edited a comment on pull request #9248:
URL: https://github.com/apache/kafka/pull/9248#issuecomment-686044360


   One unrelated test failed:
   `Build / JDK 8 / testNoConnectionLimitsByDefault – kafka.network.ConnectionQuotasTest`
   
   Also, why are there so many different builds now? What is `stage` vs `tests` ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org