[GitHub] dgrove-oss commented on a change in pull request #4073: Rename the package of controller and invoker

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #4073: Rename the package of controller and invoker
URL: https://github.com/apache/incubator-openwhisk/pull/4073#discussion_r226363945
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/WhiskConfig.scala
 ##########
 @@ -186,56 +186,56 @@ object WhiskConfig {
 }
 
 object ConfigKeys {
-  val cluster = "whisk.cluster"
-  val loadbalancer = "whisk.loadbalancer"
-  val buildInformation = "whisk.info"
+  val cluster = "org.apache.openwhisk.cluster"
 
 Review comment:
   I'm not convinced we need the extra levels here.  It should be further discussed.
   
   Even if we eventually decide to make the change, it absolutely should be a separate PR.  Changing the name of config variables is significantly higher impact on downstream projects than changing the names of the Scala/Java packages

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services