[GitHub] [activemq-artemis] jbertram commented on pull request #3412: ARTEMIS-3074 Add ActiveMQServerControl#createBridge() method variant …

[GitBox <gi...@apache.org>]

jbertram commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-762978719


   Given the proliferation of overloaded management methods it was determined awhile back that we'd move to a more de-coupled approach using flexible JSON-based input. See, for example, the method `org.apache.activemq.artemis.api.core.management.ActiveMQServerControl#createQueue(java.lang.String)` which replaces over 10 overloaded variants. The JSON input `String` for this method can be created manually simply based on the parameter names or generated from the `org.apache.activemq.artemis.api.core.QueueConfiguration` object using the `toJSON` method. I recommend you implement a similar method for `createBridge`. The class `org.apache.activemq.artemis.core.config.BridgeConfiguration` already exists and you can use that for these changes (although you'll likely need to move it out of the `activemq-server` module and into the `activemq-commons` module).
   
   I realize the change I'm describing is much larger than the one you already submitted in this PR, but the new method in this PR is just going to be deprecated in a bit so you'll have to change your integration code anyway. I think it's probably best to do it "right" the first time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org