You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/05/29 12:53:43 UTC
[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/4008
[FLINK-6736] [table] Fix UDTF field access with time attribute record
A wrong physical index caused the code generation to fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-6736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4008
----
commit 0ba039f2555c916088fe71743002e395989701ea
Author: twalthr <tw...@apache.org>
Date: 2017-05-29T12:48:14Z
[FLINK-6736] [table] Fix UDTF field access with time attribute record
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4008#discussion_r118935465
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverterTest.scala ---
@@ -391,8 +391,8 @@ object RelTimeIndicatorConverterTest {
class TableFunc extends TableFunction[String] {
val t = new Timestamp(0L)
- def eval(time1: Long, time2: Timestamp): Unit = {
- collect(time1.toString + time2.after(t))
+ def eval(time1: Long, time2: Timestamp, string: String): Unit = {
--- End diff --
Does this change cover changes in functionality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4008#discussion_r118938233
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverterTest.scala ---
@@ -391,8 +391,8 @@ object RelTimeIndicatorConverterTest {
class TableFunc extends TableFunction[String] {
val t = new Timestamp(0L)
- def eval(time1: Long, time2: Timestamp): Unit = {
- collect(time1.toString + time2.after(t))
+ def eval(time1: Long, time2: Timestamp, string: String): Unit = {
--- End diff --
Yes, it is used in `TimeAttributeITCase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4008: [FLINK-6736] [table] Fix UDTF field access with time attr...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4008
@sunjincheng121 does it fix your issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4008: [FLINK-6736] [table] Fix UDTF field access with time attr...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4008
@sunjincheng121 I will add another ITCase just to be sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---