[jira] [Commented] (SQOOP-841) Sqoop2: Remove final keyword from manager classes

["Venkat Ranganathan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560828#comment-13560828 ] 

Venkat Ranganathan commented on SQOOP-841:
------------------------------------------

+1 - It really helps with testing.   

I am thinking on the same topic of singletons, we can make the constructors private.  I can open a JIRA and provide a patch for this if we are OK with that.   Not sure whether we want setInstance() also as that seems to violate the singleton contract (though I understand the intent is to use for tests)

Thanks

                
> Sqoop2: Remove final keyword from manager classes
> -------------------------------------------------
>
>                 Key: SQOOP-841
>                 URL: https://issues.apache.org/jira/browse/SQOOP-841
>             Project: Sqoop
>          Issue Type: Improvement
>    Affects Versions: 1.99.1
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Trivial
>             Fix For: 1.99.2
>
>         Attachments: bugSQOOP-841.patch
>
>
> I've made all manager classes final in SQOOP-618 and consequently made them singleton objects in SQOOP-802. I believe that the final keyword is no longer required. Removing it will also simplify testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira