You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@poi.apache.org by bu...@apache.org on 2013/10/13 08:58:20 UTC

[Bug 55611] Performance improvement (~7% up to ~27%) by adding a cache to DateUtil.isADateFormat(int, String)

https://issues.apache.org/bugzilla/show_bug.cgi?id=55611

--- Comment #1 from Yegor Kozlov <ye...@dinom.ru> ---
Thanks for the patch. The idea is cool but not thread safe. What if
DateUtil.isADateFormat is called from two threads in parallel? I think you will
have a race condition in this case. 

I would say we should declare this method as synchronized to be on the safe
side. 
The same concern applies to
https://issues.apache.org/bugzilla/show_bug.cgi?id=55612

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org