You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/19 18:39:27 UTC

svn commit: r1894390 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java

Author: tilman
Date: Tue Oct 19 18:39:26 2021
New Revision: 1894390

URL: http://svn.apache.org/viewvc?rev=1894390&view=rev
Log:
PDFBOX-4892: remove unneeded assignment and cast

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1894390&r1=1894389&r2=1894390&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Tue Oct 19 18:39:26 2021
@@ -506,8 +506,8 @@ class AppearanceGeneratorHelper {
         float fontScaleY = fontSize / FONTSCALE;
         float fontBoundingBoxAtSize = font.getBoundingBox().getHeight() * fontScaleY;
 
-        float fontCapAtSize = 0;
-        float fontDescentAtSize = 0;
+        float fontCapAtSize;
+        float fontDescentAtSize;
 
         if (font.getFontDescriptor() != null) {
             fontCapAtSize = font.getFontDescriptor().getCapHeight() * fontScaleY;
@@ -639,7 +639,7 @@ class AppearanceGeneratorHelper {
     private void insertGeneratedCombAppearance(PDPageContentStream contents, PDAppearanceStream appearanceStream,
             PDFont font, float fontSize) throws IOException {
         int maxLen = ((PDTextField) field).getMaxLen();
-        int quadding = ((PDTextField) field).getQ();
+        int quadding = field.getQ();
         int numChars = Math.min(value.length(), maxLen);
 
         PDRectangle paddingEdge = applyPadding(appearanceStream.getBBox(), 1);