[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4003: Logging framework to use only log4j

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4003: Logging framework to use only log4j
URL: https://github.com/apache/cloudstack/pull/4003#discussion_r405309227
 
 

 ##########
 File path: framework/managed-context/src/main/java/org/apache/cloudstack/managed/context/ManagedContextRunnable.java
 ##########
 @@ -18,16 +18,15 @@
  */
 package org.apache.cloudstack.managed.context;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.log4j.Logger;
 
 import org.apache.cloudstack.managed.context.impl.DefaultManagedContext;
 
 public abstract class ManagedContextRunnable implements Runnable {
 
     private static final int SLEEP_COUNT = 120;
 
-    private static final Logger log = LoggerFactory.getLogger(ManagedContextRunnable.class);
+    private static final Logger log = Logger.getLogger(ManagedContextRunnable.class);
 
 Review comment:
   maybe not for this iteration, but this var name should be all upper i.e. LOG

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services