[GitHub] [superset] rusackas commented on a change in pull request #15907: chore: Improves the layout of the VizTypeGallery component

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #15907:
URL: https://github.com/apache/superset/pull/15907#discussion_r677614678



##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -115,31 +142,21 @@ export default class AddSliceContainer extends React.PureComponent<
 
   render() {
     return (
-      <StyledContainer className="container">
+      <StyledContainer>
         <h3 css={cssStatic}>{t('Create a new chart')}</h3>
-        <div css={cssStatic}>
-          <p>{t('Choose a dataset')}</p>
-          <div style={styleSelectContainer}>
-            <Select
-              clearable={false}
-              ignoreAccents={false}
-              name="select-datasource"
-              onChange={this.changeDatasource}
-              options={this.props.datasources}
-              placeholder={t('Choose a dataset')}
-              value={
-                this.state.datasourceValue
-                  ? {
-                      value: this.state.datasourceValue,
-                    }
-                  : undefined
-              }
-              width={600}
-            />
-          </div>
-          <span className="text-muted">
+        <div className="dataset">
+          <Select
+            ariaLabel={t('Dataset')}
+            name="select-datasource"
+            header={t('Choose a dataset')}
+            onChange={this.changeDatasource}
+            options={this.props.datasources}
+            placeholder={t('Choose a dataset')}
+            value={this.state.datasourceValue}
+          />
+          <span>
             {t(
-              'If the dataset you are looking for is not available in the list, follow the instructions on how to add it in the Superset tutorial.',
+              "If you can't find the dataset, follow the instructions on how to add it in the Superset tutorial.",

Review comment:
       ```suggestion
                 "If you can't find a dataset, follow the instructions on how to add it in the Superset tutorial.",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org