[GitHub] [sling-org-apache-sling-jcr-resource] anchela commented on pull request #10: SLING-9901 - switch Oak for tests, but no new tests so far

[GitBox <gi...@apache.org>]

anchela commented on pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/10#issuecomment-729046031


   @bdelacretaz , i originally only added tests for actualy system-users which were missing and actually would have been the most important piece of all of this.... but looking at the code again, i noticed that there is a cache built for validated service users. so, the code executed during the second call is not the same as the first one. so the test*twice should assert that subsequent isvalid calls for the same principalname/userId actually still return a correct result.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org