[GitHub] [geode] gaussianrecurrence commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730572491


   Sorry @kohlmu-pivotal and @echobravopapa but I have been quite busy these days.
   The rationale behind this change is described already in the Jira description, probably with not too much detail.
   But quickly summarizing, while starting a locator if there is an exception having to do with JGroups, the cause is not included in the top exception, hence loosing the context on what's happening. Hopefully this clarifies the intention of this fix.
   
   Regarding about whether or not to leak the exception, I don't have an strong point as Java is not my main language. But for what I can tell, there are these exceptions which are internal and we wouldn't want these to be exposed, that's why they are being wrapper as SystemConnectException and GemFireConfigException. If that's the case I don't have any problem with that, 
   
   Still,  unless I am missing something important here, what I believe is that the exception cause should be there, otherwise troubleshooting these kind of issues could be a real pain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org