You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bruno P. Kinoshita (Jira)" <ji...@apache.org> on 2019/12/15 04:02:00 UTC
[jira] [Commented] (IMAGING-158) Color component names should
follow naming conventions
[ https://issues.apache.org/jira/browse/IMAGING-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996620#comment-16996620 ]
Bruno P. Kinoshita commented on IMAGING-158:
--------------------------------------------
I think this has been fixed already. All the constants in the color components are now CYAN, BLACK, WHITE, GREEN, etc. No more simple letters used, so closing the issue.
> Color component names should follow naming conventions
> ------------------------------------------------------
>
> Key: IMAGING-158
> URL: https://issues.apache.org/jira/browse/IMAGING-158
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.color.*
> Reporter: Benedikt Ritter
> Priority: Major
>
> Checkstyle reports a lot of errors because the fields of our color classes are just single capital letters. I'm currently thinking about renaming them to their full names, so that {{ColorCmy.C}} becomes {{ColorCmy.cyan}}. Don't know if that feels better from an API user's POV. It's longer by it's more explicit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)