You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/11/27 00:49:19 UTC
Review Request 69450: Applied the `ContainerMountInfo` protobuf
helper.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69450/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
Bugs: MESOS-9319
https://issues.apache.org/jira/browse/MESOS-9319
Repository: mesos
Description
-------
Now that there is a protobuf helper to manufacture `ContainerMountInfo`
messages, apply it where appropriate.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 507665cdd3c08f6716840f2b10f2b9659e7fcf1a
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp d1938836997b177ec89c1e8d671dc6e0379aa061
src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 5b481b5e8e66104b8b7af6fa97dcb411fb0a1f5e
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 73e09636808081ce411c022bf2bcb2a157a3ad25
src/slave/containerizer/mesos/isolators/volume/host_path.cpp 88ecf91d91e2bebd484a4ac94510a14b3500dbfb
src/slave/containerizer/mesos/isolators/volume/image.cpp bb3fc659f1322d26fe3d035c961d3942c73353f0
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 300b3d95d74b73fbe0221096f3f3f172be745081
Diff: https://reviews.apache.org/r/69450/diff/1/
Testing
-------
sudo make check (Fedora 29)
Thanks,
James Peach
Re: Review Request 69450: Applied the `ContainerMountInfo` protobuf
helper.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69450/#review211014
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 27, 2018, 12:49 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69450/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2018, 12:49 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-9319
> https://issues.apache.org/jira/browse/MESOS-9319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now that there is a protobuf helper to manufacture `ContainerMountInfo`
> messages, apply it where appropriate.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 507665cdd3c08f6716840f2b10f2b9659e7fcf1a
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp d1938836997b177ec89c1e8d671dc6e0379aa061
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 5b481b5e8e66104b8b7af6fa97dcb411fb0a1f5e
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 73e09636808081ce411c022bf2bcb2a157a3ad25
> src/slave/containerizer/mesos/isolators/volume/host_path.cpp 88ecf91d91e2bebd484a4ac94510a14b3500dbfb
> src/slave/containerizer/mesos/isolators/volume/image.cpp bb3fc659f1322d26fe3d035c961d3942c73353f0
> src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 300b3d95d74b73fbe0221096f3f3f172be745081
>
>
> Diff: https://reviews.apache.org/r/69450/diff/2/
>
>
> Testing
> -------
>
> sudo make check (Fedora 29)
>
>
> Thanks,
>
> James Peach
>
>