[GitHub] [maven-release] cstamas commented on pull request #100: Handle edge case for m-p-p

[GitBox <gi...@apache.org>]

cstamas commented on pull request #100:
URL: https://github.com/apache/maven-release/pull/100#issuecomment-1023946463


   @hboutemy so, when you build a `maven-plugin` you MUST use m-p-p to build it. Moreover, when you build m-p-p itself, you MUST use m-p-p to build it. 
   
   OTOH, in a bit more complex (or repeated declarations, like buildPlugin + reportPlugin) use of a plugin, it is "best practice" to define it's version using property, and use `${placeholder}` for m-p-p plugin (and corresponding report plugin) definition in POM. BUT, m-release-p tries to resolve that placeholder, and comes to these IF/ELSE branches that FAILS the build.
   
   As |I see, m-release-p tampers properties if it finds ANYTHING that has GA of "this" project (currently released), and does some extra work with placeholders, BUT at the same time, it misses a lot, like inherited properties (at least comments suggests that) etc. All this prevents building m-p-p IF m-p-p used to build it has version defined as property.
   
   If you generalize this, you get the MRELEASE-799 where GA of currently built project is used with other version as dep/plugin (like they do for some sort of testing).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org