[jira] [Resolved] (SOLR-17994) Rename HttpClientBuilderFactory to SolrClientCustomizer

["David Smiley (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-17994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved SOLR-17994.
---------------------------------
    Fix Version/s: 10.0
       Resolution: Fixed

> Rename HttpClientBuilderFactory to SolrClientCustomizer
> -------------------------------------------------------
>
>                 Key: SOLR-17994
>                 URL: https://issues.apache.org/jira/browse/SOLR-17994
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 10.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> HttpClientBuilderFactory's name doesn't make sense anymore, if it ever did.  It has evolved.  It's not a factory for a builder of HttpClients, as its name might suggest.  It's a customizer for a SolrClient that was recently constructed.  At present it's only used for Http2SolrClient (Jetty) but it's quite plausible to imagine using it for the JDK one, if we so choose.  We might evolve it to configure a builder, which would be nice because it would make it easier to make clients immutable (no back-doors).  Still, calling this a SolrClient customizer still sounds like a good name.  But it's not a factory, and it's not a builder!  It's definitely a customizer/configurer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org