[GitHub] [arrow-rs] alamb commented on a diff in pull request #1517: Fix reading nested lists from parquet files

[GitBox <gi...@apache.org>]

alamb commented on code in PR #1517:
URL: https://github.com/apache/arrow-rs/pull/1517#discussion_r844220204


##########
parquet/src/arrow/array_reader.rs:
##########
@@ -2268,4 +2272,67 @@ mod tests {
             &PrimitiveArray::<ArrowInt32>::from(vec![Some(3), Some(4)])
         );
     }
+
+    #[test]
+    fn test_nested_lists() {

Review Comment:
   I tested running this test without the rest of the code change in this PR and I got:
   
   ```
   ---- arrow::array_reader::tests::test_nested_lists stdout ----
   thread 'arrow::array_reader::tests::test_nested_lists' panicked at 'called `Option::unwrap()` on a `None` value', parquet/src/arrow/array_reader/builder.rs:327:14
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ```



##########
parquet/src/arrow/array_reader/builder.rs:
##########
@@ -321,70 +323,71 @@ impl<'a> TypeVisitor<Option<Box<dyn ArrayReader>>, &'a ArrayReaderBuilderContext
             _ => (),
         }
 
-        let item_reader = self
-            .dispatch(item_type.clone(), &new_context)
-            .unwrap()
-            .unwrap();

Review Comment:
   👍  I found using a whitespace blind diff made the changes easier to understand: https://github.com/apache/arrow-rs/pull/1517/files?w=1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org