svn commit: r1719239 - in /river/jtsk/trunk: ./ qa/ src/org/apache/river/jeri/internal/mux/MuxClient.java

[pe...@apache.org]

Author: peter_firmstone
Date: Thu Dec 10 23:49:55 2015
New Revision: 1719239

URL: http://svn.apache.org/viewvc?rev=1719239&view=rev
Log:
Fix problem with recent commit for JERI mux fix for jtreg stability tests, In this case an int was cast to a byte (this was not intended) and then compared to an int. This cast has been removed, it was an unintended coding error. This has been fixed because the byte would overflow and prevent the comparison from working, it would have been a critical bug.  TODO: for River 3.0.1 create a test case to ensure this section of code is tested, no tests presently confirm whether the condition in this section of code is met.

Modified:
    river/jtsk/trunk/   (props changed)
    river/jtsk/trunk/qa/   (props changed)
    river/jtsk/trunk/src/org/apache/river/jeri/internal/mux/MuxClient.java

Propchange: river/jtsk/trunk/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Thu Dec 10 23:49:55 2015
@@ -12,4 +12,5 @@ LICENSE.txt
 doc
 le
 NOTICE.txt
+netbeans
 .*

Propchange: river/jtsk/trunk/qa/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Thu Dec 10 23:49:55 2015
@@ -1,13 +1,14 @@
-hs_err_pid4712.log
+hs_err_pid5956.log
+lib
+soul
 classes
-result
+hs_err_pid4712.log
 riverruntimelastbuild
-soul
-build
+result
 LeaseRenewDurRFE-sharedVMDir-TestService_0
-hs_err_pid5956.log
 lib-ext
-hs_err_pid9196.log
-lib
-build.properties
+LeaseRenewDurRFE-sharedVMDir-TestService_1
 hs_err_pid10959.log
+build.properties
+build
+hs_err_pid9196.log

Modified: river/jtsk/trunk/src/org/apache/river/jeri/internal/mux/MuxClient.java
URL: http://svn.apache.org/viewvc/river/jtsk/trunk/src/org/apache/river/jeri/internal/mux/MuxClient.java?rev=1719239&r1=1719238&r2=1719239&view=diff
==============================================================================
--- river/jtsk/trunk/src/org/apache/river/jeri/internal/mux/MuxClient.java (original)
+++ river/jtsk/trunk/src/org/apache/river/jeri/internal/mux/MuxClient.java Thu Dec 10 23:49:55 2015
@@ -69,7 +69,7 @@ public class MuxClient extends Mux {
 		ioe.initCause(muxDownCause);
 		throw ioe;
 	    }
-	    byte sessionID = (byte) busySessions.nextClearBit(0);
+	    int sessionID = busySessions.nextClearBit(0);
 	    if (sessionID > Mux.MAX_SESSION_ID) {
 		throw new IOException("no free sessions");
 	    }