You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2012/04/10 23:38:35 UTC

svn commit: r1312006 - in /tomcat/trunk/java/org/apache/catalina/core: AprLifecycleListener.java LocalStrings.properties LocalStrings_es.properties

Author: schultz
Date: Tue Apr 10 21:38:35 2012
New Revision: 1312006

URL: http://svn.apache.org/viewvc?rev=1312006&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53057
Add OpenSSL version number to INFO log message when initializing

Modified:
    tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
    tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
    tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties

Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java?rev=1312006&r1=1312005&r2=1312006&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Tue Apr 10 21:38:35 2012
@@ -276,6 +276,8 @@ public class AprLifecycleListener
             }
         }
 
+        log.info(sm.getString("aprListener.initializedOpenSSL", SSL.versionString()));
+
         sslAvailable = true;
     }
 

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=1312006&r1=1312005&r2=1312006&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Tue Apr 10 21:38:35 2012
@@ -58,6 +58,7 @@ aprListener.initializeFIPSFailed=Failed 
 aprListener.tooLateForSSLEngine=Cannot setSSLEngine: SSL has already been initialized
 aprListener.tooLateForSSLRandomSeed=Cannot setSSLRandomSeed: SSL has already been initialized
 aprListener.tooLateForFIPSMode=Cannot setFIPSMode: SSL has already been initialized
+aprListener.initializedOpenSSL=OpenSSL {0} successfully initialized
 
 asyncContextImpl.requestEnded=The request associated with the AsyncContext has already completed processing.
 containerBase.threadedStartFailed=A child container failed during start

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties?rev=1312006&r1=1312005&r2=1312006&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties (original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties Tue Apr 10 21:38:35 2012
@@ -51,6 +51,7 @@ aprListener.aprDestroy = No pude apagar 
 aprListener.sslInit = No pude inicializar el SSLEngine (Motor SSL)
 aprListener.tcnValid = Cargada la biblioteca nativa APR de Apache Tomcat {0} con la versiĆ³n APR {1}.
 aprListener.flags = Capacidades APR\: IPv6 [{0}], enviar fichero [{1}], aceptar filtros [{2}], aleatorio [{3}].
+aprListener.initializedOpenSSL=OpenSSL {0} inicializado correctamente
 asyncContextImpl.requestEnded = El requerimiento asociado con AsyncContext ya ha completado su procesamiento.
 containerBase.backgroundProcess.cluster = Excepci\u00F3n al procesar cl\u00FAster {0} de proceso en segundo plano
 containerBase.backgroundProcess.loader = Excepci\u00F3n al procesar cargador {0} de proceso en segundo plano



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1312006 - in /tomcat/trunk/java/org/apache/catalina/core: AprLifecycleListener.java LocalStrings.properties LocalStrings_es.properties

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Konstantin,

On 4/10/12 7:27 PM, Konstantin Kolinko wrote:
> 2012/4/11  <sc...@apache.org>:
>> Author: schultz
>> Date: Tue Apr 10 21:38:35 2012
>> New Revision: 1312006
>>
>> URL: http://svn.apache.org/viewvc?rev=1312006&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53057
>> Add OpenSSL version number to INFO log message when initializing
>> +aprListener.initializedOpenSSL=OpenSSL {0} successfully initialized
>> +aprListener.initializedOpenSSL=OpenSSL {0} inicializado correctamente
> 
> 
> It works. ;)  Though it prints "OpenSSL OpenSSL".

Yeah, I noticed that... SSL.versionString() returns "OpenSSL" as part of
the version string itself.

> Maybe redefine the message to print the version at the end, like this:
> INFO: OpenSSL successfully initialized, using OpenSSL 1.0.0g 18 Jan 2012

Sure, I could do that.

> I do not know how that will be in Spanish.

I just used Google Translate for the Spanish. It seemed like the _es
bundle had most strings while the _jp and others didn't, so I followed suit.

> (Maybe there can be some better text. I wish it were more
> understandable that it is part of Tomcat-Native).

I'm open to suggestions.

-chris



Re: svn commit: r1312006 - in /tomcat/trunk/java/org/apache/catalina/core: AprLifecycleListener.java LocalStrings.properties LocalStrings_es.properties

Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/4/11  <sc...@apache.org>:
> Author: schultz
> Date: Tue Apr 10 21:38:35 2012
> New Revision: 1312006
>
> URL: http://svn.apache.org/viewvc?rev=1312006&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53057
> Add OpenSSL version number to INFO log message when initializing
> +aprListener.initializedOpenSSL=OpenSSL {0} successfully initialized
> +aprListener.initializedOpenSSL=OpenSSL {0} inicializado correctamente


It works. ;)  Though it prints "OpenSSL OpenSSL".


[[[
11.04.2012 3:16:00 org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.23 using APR version 1.4
.6.
11.04.2012 3:16:00 org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], ra
ndom [true].
11.04.2012 3:16:00 org.apache.catalina.core.AprLifecycleListener initializeSSL
INFO: OpenSSL OpenSSL 1.0.0g 18 Jan 2012 successfully initialized
]]]


Maybe redefine the message to print the version at the end, like this:
INFO: OpenSSL successfully initialized, using OpenSSL 1.0.0g 18 Jan 2012

I do not know how that will be in Spanish.

(Maybe there can be some better text. I wish it were more
understandable that it is part of Tomcat-Native).


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org