[GitHub] [pulsar] flowchartsman commented on a change in pull request #8365: [Go functions] Provide pre-start access to secrets and conf

[GitBox <gi...@apache.org>]

flowchartsman commented on a change in pull request #8365:
URL: https://github.com/apache/pulsar/pull/8365#discussion_r515972686



##########
File path: pulsar-function-go/pf/context.go
##########
@@ -119,6 +118,15 @@ func (c *FunctionContext) GetUserConfMap() map[string]interface{} {
 	return c.userConfigs
 }
 
+func (c *FunctionContext) GetSecretsMap() map[string]interface{} {

Review comment:
       So, according to the setup code I looked at, the secrets are already getting sent into the function context, just not actually referenced anywhere. Is the concern that the existing method doesn't allow for a pluggable `SecretsProvider` interface? If so, that makes sense and I'll amend the PR and we can address it later. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org