You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yujhe (via GitHub)" <gi...@apache.org> on 2023/10/11 03:46:10 UTC
Re: [PR] [SPARK-41952][SQL] Fix Parquet zstd off-heap memory leak as a workaround for PARQUET-2160 [spark]
yujhe commented on PR #40091:
URL: https://github.com/apache/spark/pull/40091#issuecomment-1756720258
@pan3793 We found that in some cases this workaround did not work when reading Parquet files in zstd codec and outputting it to a new path.
```scala
val df = spark.read.parquet("zstd_parquet_file")
df.repartition(3).write.mode("overwrite").parquet("/tmp/test")
```
In debug mode, you can see it won't set ParquetCodecFactory when initializing `org.apache.parquet.hadoop.ParquetFileReader` which is called from [ParquetFileFormat.buildReaderWithPartitionValues](https://github.com/apache/spark/blob/branch-3.3/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L405C32-L405C32).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org