You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/10 23:40:57 UTC
Review Request 26276: SQOOP2: rename Type to Column Type+ minor doc
fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/
-----------------------------------------------------------
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP2: rename Type to Column Type+ minor doc fixes
Bugs: SQOOP-1703
https://issues.apache.org/jira/browse/SQOOP-1703
Repository: sqoop-SQOOP-1367
Description (updated)
-------
ssee jira.
No functional change
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
Diff: https://reviews.apache.org/r/26276/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor
doc fixes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/#review60715
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Nov. 10, 2014, 11:53 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26276/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 11:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1703
> https://issues.apache.org/jira/browse/SQOOP-1703
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> ssee jira.
>
> rename type to column type ( since it is enum representing columns)
> rename size on stirng to length, again a nitpick, since it is in line with java string class
>
> No functional change
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
> common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java d84c7ec
> common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
> common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
> common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
> common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
> common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
> common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
>
> Diff: https://reviews.apache.org/r/26276/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor
doc fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 3:53 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1703
https://issues.apache.org/jira/browse/SQOOP-1703
Repository: sqoop-SQOOP-1367
Description
-------
ssee jira.
rename type to column type ( since it is enum representing columns)
rename size on stirng to length, again a nitpick, since it is in line with java string class
No functional change
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java d84c7ec
common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
Diff: https://reviews.apache.org/r/26276/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor
doc fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 3:09 p.m.)
Review request for Sqoop.
Changes
-------
this rev renames size to length ( again as said before a nitpick to be consistent with java string class)
Bugs: SQOOP-1703
https://issues.apache.org/jira/browse/SQOOP-1703
Repository: sqoop-SQOOP-1367
Description
-------
ssee jira.
rename type to column type ( since it is enum representing columns)
rename size on stirng to length, again a nitpick, since it is in line with java string class
No functional change
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java d84c7ec
common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
Diff: https://reviews.apache.org/r/26276/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor
doc fixes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/#review60700
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Nov. 10, 2014, 10:49 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26276/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 10:49 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1703
> https://issues.apache.org/jira/browse/SQOOP-1703
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> ssee jira.
>
> rename type to column type ( since it is enum representing columns)
> rename size on stirng to length, again a nitpick, since it is in line with java string class
>
> No functional change
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
> common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
> common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
> common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
> common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
> common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
> common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
> common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
>
> Diff: https://reviews.apache.org/r/26276/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26276: SQOOP2: rename Type to Column Type+ minor
doc fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26276/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 2:49 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1703
https://issues.apache.org/jira/browse/SQOOP-1703
Repository: sqoop-SQOOP-1367
Description (updated)
-------
ssee jira.
rename type to column type ( since it is enum representing columns)
rename size on stirng to length, again a nitpick, since it is in line with java string class
No functional change
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 4b4b932
common/src/main/java/org/apache/sqoop/schema/Schema.java 3aa3aea
common/src/main/java/org/apache/sqoop/schema/type/Array.java cbf8f6e
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 53e50b8
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 3c522bf
common/src/main/java/org/apache/sqoop/schema/type/Column.java 97bd303
common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java 3d1bffe
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 502f328
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java ffd3eab
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 48fd048
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 77adfb1
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java ceff011
common/src/main/java/org/apache/sqoop/schema/type/Map.java 2dd70d8
common/src/main/java/org/apache/sqoop/schema/type/Set.java c9a658f
common/src/main/java/org/apache/sqoop/schema/type/Text.java 550e2b6
common/src/main/java/org/apache/sqoop/schema/type/Time.java 095fac0
common/src/main/java/org/apache/sqoop/schema/type/Type.java 7fca3c8
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java e09bc48
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java e65edd9
Diff: https://reviews.apache.org/r/26276/diff/
Testing
-------
Thanks,
Veena Basavaraj