You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 15:02:28 UTC

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

romainfrancois commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-755350170


   At the point now where I dropped the artificial `Rscalar` class and all goes through `AppendRange()` which is only slightly different from @kszucs take on #8886. 
   
   Mostly because `AppendRange()` takes start and size when IIUC `Extend()` assumes `start = 0`. 
   
   I could "easily" align to what #8886 does, because at the moment I'm only ever using `start = 0` anyway, but the logic behind having a `start` was to facilitate one R vector contributing to two different chunks in the chunker ... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org