[jira] [Commented] (HBASE-7997) One last set of class moves before 0.95 goes out

["Elliott Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592811#comment-13592811 ] 

Elliott Clark commented on HBASE-7997:
--------------------------------------

The exceptions were put into hbase-client because some of them depend upon the protobuf classes in hbase-protocol and any exceptions that can possibly make it into the client need to be accessible in hbase-client.  
They were moved into the .exceptions namespace so that hbase-client doesn't have a regionserver namespace.  That seemed too weird.  And it makes placement of exceptions pretty easy to understand.  They all go in the same module under the same namespace.
 
Best would be that none of the exceptions depend upon protobuf and they all can go into hbase-common.
Next best imo would be having them in hbase-client.


Though I could be convinced that the .exception namespace was not a good idea.
                
> One last set of class moves before 0.95 goes out
> ------------------------------------------------
>
>                 Key: HBASE-7997
>                 URL: https://issues.apache.org/jira/browse/HBASE-7997
>             Project: HBase
>          Issue Type: Task
>          Components: Usability
>            Reporter: stack
>            Priority: Critical
>             Fix For: 0.95.0
>
>
> hbase-server depends on hbase-client.  Alot of exceptions are in hbase-client that are thrown by the hbase-server.  Should these be in a common place instead of in hbase-client explicitly?  Say in hbase-common?  The client move put all of our exceptions into an exception package (apparently this is my fault).  Is this a good idea?  How many of these exceptions can we put beside the place where they are thrown?
> This issue is about spending a few hours looking at class locations before 0.95 goes out.
> Any other ideas?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira