You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/08 19:03:13 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14570: [WIP] use a compile flag to use int64 tensor size

reminisce commented on a change in pull request #14570: [WIP] use a compile flag to use int64 tensor size
URL: https://github.com/apache/incubator-mxnet/pull/14570#discussion_r273193355
 
 

 ##########
 File path: include/mxnet/tensor_blob.h
 ##########
 @@ -456,7 +456,7 @@ class FieldEntry<mxnet::TShape>
     this->enforce_nonzero_ = true;
     return this->self();
   }
-  inline FieldEntry<mxnet::TShape> &set_expect_ndim(mxnet::index_t ndim) {
+  inline FieldEntry<mxnet::TShape> &set_expect_ndim(int ndim) {
 
 Review comment:
   We are changing `ndim` to `int` so that `ndim = -1` can be used to indicate unknown shapes, while `ndim = 0` is for scalar tensors as in numpy. So I'm rooting for this change here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services