[jira] [Comment Edited] (KARAF-4666) Have karaf write pid file by default

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438743#comment-15438743 ] 

Guillaume Nodet edited comment on KARAF-4666 at 8/26/16 10:00 AM:
------------------------------------------------------------------

You're right, but I want to make sure there's no conflict in the file names.
There's a suggestion to move the wrapper pid file into KARAF_BASE too.

Also, I wonder if we should improve {{bin/stop}} to leverage the pid to call {{kill [pid]}}, especially if the shutdown port has been disabled, see KARAF-3825.

Also what's the need for renaming the property ? I don't mind, the new name is more generic, but maybe we should keep compatibility by reading the new property and if not defined, reading the old, to preserve compatibility ?


was (Author: gnt):
You're right, but I want to make sure there's no conflict in the file names.
There's a suggestion to move the wrapper pid file into KARAF_BASE too.

Also, I wonder if we should improve {{bin/stop}} to leverage the pid to call {{kill [pid]}}, especially if the shutdown port has been disabled, see KARAF-3825.

> Have karaf write pid file by default
> ------------------------------------
>
>                 Key: KARAF-4666
>                 URL: https://issues.apache.org/jira/browse/KARAF-4666
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-core
>            Reporter: Luca Burgazzoli
>            Priority: Minor
>
>  As today karaf would write the pid file only if karaf.shutdown.pid.file is defined but it would be nice to have a pid file always written.
> So I will open a PR with:
> - karaf.shutdown.pid.file renamed to karaf.pid.file
> - set default value to ${karaf.base}/karaf.pid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)