[jira] [Commented] (BOOKKEEPER-900) read only bookie runs replicator and does not release the under replicated lock after failing

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184498#comment-15184498 ] 

ASF GitHub Bot commented on BOOKKEEPER-900:
-------------------------------------------

Github user sijie commented on the pull request:

    https://github.com/apache/bookkeeper/pull/17#issuecomment-193622509
  
    the change looks good to me +1


> read only bookie runs replicator and does not release the under replicated lock after failing
> ---------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-900
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-900
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-auto-recovery
>    Affects Versions: 4.3.2
>            Reporter: Siddharth Sunil Boobna
>            Assignee: Siddharth Sunil Boobna
>
> ReplicationWorker throws BkWriteOnReadOnlyBookieException here: https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L255
> and does not release the under replicated lock.
> Solution:
> Release the under replicated lock before throwing BkWriteOnReadOnlyBookieException and make the replication worker wait till the bookie becomes writable again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)