You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/01 10:21:03 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #201: [YUNIKORN-390] Panic in placement rule evaluation
codecov[bot] commented on pull request #201:
URL: https://github.com/apache/incubator-yunikorn-core/pull/201#issuecomment-684734683
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=h1) Report
> Merging [#201](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/57d663e73cb10674873b119ae1eaf61ad43fdcd9?el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201/graphs/tree.svg?width=650&height=150&src=pr&token=SB9NrIi3Hy)](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 60.61% 60.88% +0.26%
==========================================
Files 67 67
Lines 6533 6537 +4
==========================================
+ Hits 3960 3980 +20
+ Misses 2427 2419 -8
+ Partials 146 138 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/placement/fixed\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZml4ZWRfcnVsZS5nbw==) | `76.00% <100.00%> (+12.73%)` | :arrow_up: |
| [pkg/scheduler/placement/provided\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcHJvdmlkZWRfcnVsZS5nbw==) | `80.00% <100.00%> (+9.54%)` | :arrow_up: |
| [pkg/scheduler/placement/tag\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdGFnX3J1bGUuZ28=) | `80.00% <100.00%> (+4.48%)` | :arrow_up: |
| [pkg/scheduler/placement/user\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdXNlcl9ydWxlLmdv) | `78.57% <100.00%> (+10.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=footer). Last update [57d663e...ba82469](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org