You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/10/02 21:30:14 UTC

Review Request 38964: QPID-6767: Add --sasl-service-name option to the QPID tools

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38964/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Bugs: qpid-6767
    https://issues.apache.org/jira/browse/qpid-6767


Repository: qpid


Description
-------

Adds new option to all the command line based QPID tools


Diffs
-----

  trunk/qpid/extras/qmf/src/py/qmf/console.py 1705310 
  trunk/qpid/tools/src/py/qpid-config 1705310 
  trunk/qpid/tools/src/py/qpid-ha 1705310 
  trunk/qpid/tools/src/py/qpid-printevents 1705310 
  trunk/qpid/tools/src/py/qpid-queue-stats 1705310 
  trunk/qpid/tools/src/py/qpid-route 1705310 
  trunk/qpid/tools/src/py/qpid-stat 1705310 
  trunk/qpid/tools/src/py/qpid-tool 1705310 

Diff: https://reviews.apache.org/r/38964/diff/


Testing
-------

Tested all commands against a broker configured with SASL authentication (DIGEST-MD5) and it's sasl-service-name as "amqp".


Thanks,

Kenneth Giusti


Re: Review Request 38964: QPID-6767: Add --sasl-service-name option to the QPID tools

Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38964/#review101449
-----------------------------------------------------------

Ship it!


Ship It!

- Gordon Sim


On Oct. 2, 2015, 7:30 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38964/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 7:30 p.m.)
> 
> 
> Review request for qpid and Gordon Sim.
> 
> 
> Bugs: qpid-6767
>     https://issues.apache.org/jira/browse/qpid-6767
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Adds new option to all the command line based QPID tools
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/extras/qmf/src/py/qmf/console.py 1705310 
>   trunk/qpid/tools/src/py/qpid-config 1705310 
>   trunk/qpid/tools/src/py/qpid-ha 1705310 
>   trunk/qpid/tools/src/py/qpid-printevents 1705310 
>   trunk/qpid/tools/src/py/qpid-queue-stats 1705310 
>   trunk/qpid/tools/src/py/qpid-route 1705310 
>   trunk/qpid/tools/src/py/qpid-stat 1705310 
>   trunk/qpid/tools/src/py/qpid-tool 1705310 
> 
> Diff: https://reviews.apache.org/r/38964/diff/
> 
> 
> Testing
> -------
> 
> Tested all commands against a broker configured with SASL authentication (DIGEST-MD5) and it's sasl-service-name as "amqp".
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Re: Review Request 38964: QPID-6767: Add --sasl-service-name option to the QPID tools

Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38964/#review101357
-----------------------------------------------------------

Ship it!


Ship It!

- Ted Ross


On Oct. 2, 2015, 3:30 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38964/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 3:30 p.m.)
> 
> 
> Review request for qpid and Gordon Sim.
> 
> 
> Bugs: qpid-6767
>     https://issues.apache.org/jira/browse/qpid-6767
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Adds new option to all the command line based QPID tools
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/extras/qmf/src/py/qmf/console.py 1705310 
>   trunk/qpid/tools/src/py/qpid-config 1705310 
>   trunk/qpid/tools/src/py/qpid-ha 1705310 
>   trunk/qpid/tools/src/py/qpid-printevents 1705310 
>   trunk/qpid/tools/src/py/qpid-queue-stats 1705310 
>   trunk/qpid/tools/src/py/qpid-route 1705310 
>   trunk/qpid/tools/src/py/qpid-stat 1705310 
>   trunk/qpid/tools/src/py/qpid-tool 1705310 
> 
> Diff: https://reviews.apache.org/r/38964/diff/
> 
> 
> Testing
> -------
> 
> Tested all commands against a broker configured with SASL authentication (DIGEST-MD5) and it's sasl-service-name as "amqp".
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>