[GitHub] [madlib] kaknikhil commented on a change in pull request #408: DL: Fix predict with 'NULL' string class values

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #408: DL: Fix predict with 'NULL' string class values
URL: https://github.com/apache/madlib/pull/408#discussion_r291764753
 
 

 ##########
 File path: src/ports/postgres/modules/utilities/utilities.py_in
 ##########
 @@ -458,7 +458,18 @@ def create_cols_from_array_sql_string(py_list, sql_array_col, colname,
         _assert(py_list.count(None) <= 1,
                 "{0}: Input list should contain at most 1 None element.".
                     format(module_name))
-        py_list = ['NULL' if ele is None else ele for ele in py_list]
 
 Review comment:
   Can we add this note
   ```
    NOTE: In predict, if we use 'prob' as the pred_type, we create a column
   for each distinct class level. The column name for Postgres NULL class
   level is 'prob_NULL', and the column name for a 'NULL' string class
   value will be 'prob_"NULL'.
   ``` 
   to the docstring ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services