You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:26:17 UTC

[GitHub] [pulsar] freeznet opened a new pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

freeznet opened a new pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192


   Fixes #9183 
   
   ### Motivation
   
   Pulsar functions document for Kubernetes runtime missing some configs, such as `changeConfigMap`, `changeConfigMapNamespace`, etc.
   
   This pr add the missing parameters' documents, and `functions_worker.yml` as well.
   
   ### Modifications
   
   - add documents to `functions-runtime.md`
   - align the paramters to `functions_worker.yml`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192#issuecomment-759782489


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jennifer88huang commented on pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192#issuecomment-759975921


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jennifer88huang commented on pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192#issuecomment-759976954


   > > Thank you @freeznet
   > > I was wondering if we cite a long example from a yaml file, would it better if we use a reference link in the doc in the future.
   > 
   > @Jennifer88huang thats great idea, such as a link to github file content with correct version tag.
   
   @freeznet I couldn't agree more. A link works for it ensures the correctness and consistence between doc and code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet commented on pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192#issuecomment-759855363


   > Thank you @freeznet
   > I was wondering if we cite a long example from a yaml file, would it better if we use a reference link in the doc in the future.
   
   @Jennifer88huang thats great idea, such as a link to github file content with correct version tag.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9192:
URL: https://github.com/apache/pulsar/pull/9192


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org