You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2022/10/17 07:51:28 UTC
Review Request 74174: Deprecate support for application/xml of all Ranger Rest APIs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74174/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-2928
https://issues.apache.org/jira/browse/RANGER-2928
Repository: ranger
Description
-------
While using content-type is application/xml , we are facing issues
During marshalling, the below is not getting mapped
List<HashMap<String, List<String>>> resources;
https://github.com/apache/ranger/blob/master/agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java#L135
It seems we need to add XmlAdapter to convert between unmappable and mappable objects
Refer:
http://blog.bdoughan.com/2010/07/xmladapter-jaxbs-secret-weapon.html
The similar issues ,we might encounter in some of our exposed rest api's as well .
Based on discussion with Madhan Neethiraj ,
We will deprecate the support for XML format
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java d39fb45d1
security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 5e0bbd592
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 43092ae7e
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 18d52fea3
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java ddff5cd23
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java fd2b6aecf
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c3a65a115
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java ec522dd67
security-admin/src/main/java/org/apache/ranger/rest/UserREST.java 203d725e7
security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java f8dfef029
security-admin/src/main/java/org/apache/ranger/rest/XKeyREST.java ad3e21e95
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 02ab8a1cf
Diff: https://reviews.apache.org/r/74174/diff/1/
Testing
-------
Thanks,
Ramachandran Krishnan
Re: Review Request 74174: Deprecate support for application/xml of all Ranger Rest APIs
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74174/#review224807
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 17, 2022, 7:51 a.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74174/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2022, 7:51 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2928
> https://issues.apache.org/jira/browse/RANGER-2928
>
>
> Repository: ranger
>
>
> Description
> -------
>
> While using content-type is application/xml , we are facing issues
>
> During marshalling, the below is not getting mapped
> List<HashMap<String, List<String>>> resources;
>
> https://github.com/apache/ranger/blob/master/agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java#L135
>
> It seems we need to add XmlAdapter to convert between unmappable and mappable objects
>
> Refer:
> http://blog.bdoughan.com/2010/07/xmladapter-jaxbs-secret-weapon.html
>
> The similar issues ,we might encounter in some of our exposed rest api's as well .
>
> Based on discussion with Madhan Neethiraj ,
> We will deprecate the support for XML format
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java d39fb45d1
> security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 5e0bbd592
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 43092ae7e
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 18d52fea3
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java ddff5cd23
> security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java fd2b6aecf
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c3a65a115
> security-admin/src/main/java/org/apache/ranger/rest/TagREST.java ec522dd67
> security-admin/src/main/java/org/apache/ranger/rest/UserREST.java 203d725e7
> security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java f8dfef029
> security-admin/src/main/java/org/apache/ranger/rest/XKeyREST.java ad3e21e95
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 02ab8a1cf
>
>
> Diff: https://reviews.apache.org/r/74174/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>