[Impala-ASF-CR] IMPALA-15201: Enable comparison operators and predicates for UUID type

["Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>]

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24506 )

Change subject: IMPALA-15201: Enable comparison operators and predicates for UUID type
......................................................................


Patch Set 6:

(2 comments)

Looks good to me, just had comments about casting.

http://gerrit.cloudera.org:8080/#/c/24506/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24506/6//COMMIT_MSG@11
PS6, Line 11: minimal implicit STRING->UUID
I think we should start with explicit CAST support only, later we can think of adding implicit casts. E.g. currently Trino also rejects implicit casts to UUID.

We can think about adding UUID literals, similar to literal dates (DATE '2026-09-02'): UUID '00ff...'. E.g PostgreSQL, DuckDB, Trino have this, but we should add this in a separate ticket I think.


http://gerrit.cloudera.org:8080/#/c/24506/6/fe/src/main/java/org/apache/impala/analysis/CastExpr.java
File fe/src/main/java/org/apache/impala/analysis/CastExpr.java:

http://gerrit.cloudera.org:8080/#/c/24506/6/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@394
PS6, Line 394:     if (!isImplicit_ && ((childType.isUuid() && type_.isStringType())
             :         || (childType.isStringType() && type_.isUuid()))) {
             :       throw new AnalysisException("Invalid type cast of " + getChild(0).toSql() +
             :           " from " + childType + " to " + type_);
             :     }
I think we should first allow explicit CASTs from STRING to UUID, then we can think about adding implicit casts.



-- 
To view, visit http://gerrit.cloudera.org:8080/24506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8c4c631ccc25a5f2da3540c2d18cf9dba79fe9
Gerrit-Change-Number: 24506
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2026 14:29:38 +0000
Gerrit-HasComments: Yes